Add NPM Publishing workflow #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmoseley
reviewed
Jun 21, 2024
| @@ -13,7 +13,7 @@ | |||
| "typescript-eslint": "^7.13.1", | |||
| "vitest": "^1.6.0" | |||
| }, | |||
| "name": "cortex-sdk", | |||
| "name": "@cortexclick/cortex", | |||
There was a problem hiding this comment.
I'm worried this package name is confusing. Should it be like @cortexclick/js or @cortexclick/sdk? cortex does not really describe this package.
There was a problem hiding this comment.
People do all sorts of differnt things with package names. I prefer to stick to something branded for the SDK. Similar to openAI and pulumi:
- OpenAI's SDK is just called
openaihttps://www.npmjs.com/package/openai - Pulumi's SDK is
@pulumi/pulumihttps://www.npmjs.com/package/@pulumi/pulumi
But others do just use sdk:
There was a problem hiding this comment.
And cortex is the key noun for our offering. A cortex is a customizable AI agent for marketing/sales automation that let's you operate over your enterprise data.
We will have some work to do one the marketing and brand awareness side, but I think we should lean into it and not away from it.
jmoseley
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also removes global state for tests. I created the NPM org
@cortexclickand the package will be published under@cortexclick/cortex.Will run the first release after this is merged, there is a chance there will be some trial/error getting things completely working e2e, but unfortunately can't do much testing without merging this workflow.