Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an API to list cortexes; fix content tests; use fully-qualified Pulumi env names #55

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

chaosrealm
Copy link
Contributor

@chaosrealm chaosrealm commented Nov 26, 2024

  • Add an API to list cortexes
  • Fix content tests: clean up catalogs / cortexes and use more descriptive names
  • Use fully qualified Pulumi environment names to resolve warnings
  • Error handling improvements

@chaosrealm chaosrealm requested review from jmoseley and a team November 26, 2024 04:40
Copy link
Contributor

@jmoseley jmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't need to worry about pagination right? Generally not a lot of cortexes.

@chaosrealm
Copy link
Contributor Author

I guess we don't need to worry about pagination right? Generally not a lot of cortexes.

Yeah I'm deferring pagination until someone needs it. I was able to list 940 cortexes without pagination.

@chaosrealm chaosrealm changed the title Add an API to list cortexes Add an API to list cortexes; fix content tests; use fully-qualified Pulumi env names Nov 26, 2024
use fully qualified names for Pulumi namespaces;
error handling improvements
@chaosrealm chaosrealm merged commit f1008a8 into main Nov 26, 2024
4 checks passed
@chaosrealm chaosrealm deleted the eugene_content_test_refactoring branch November 26, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants