Neighborhood/Dowker Lifting (Graph2Simplicial) (icml24-6) #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Transform pipeline
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
test request
luisfpereira
force-pushed
the
icml2024-pr6
branch
from
17229a7 to
84244ac
Compare
luisfpereira
force-pushed
the
icml2024-pr6
branch
from
84244ac to
ac22a74
Compare
luisfpereira
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in pyt-team/challenge-icml-2024#6.
Points to consider:
need to compare with Neighborhood Lifting (Graph to Cell) (icml24-5) #134 TODO: update docstring after going through this
first instance of a
Graph2SimplicialLiftingTransformthat acts on data rather than on anx.GraphTODO: maybe homogenize instead?maybe add test for node features?
original PR message added as module docstring
tutorial disregarded
NB: need to merge #116 first
Edit: tests pass locally; need to check why fail here