Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various wording fixes #1080

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Various wording fixes #1080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02b3ede
miscellaneous fixes to the French translation
fvanderbiest Sep 21, 2024
ee8f440
revisiting en.json
fvanderbiest Sep 23, 2024
b61db54
various translation improvements after review
LHBruneton-C2C Jan 20, 2025
e4a2f4e
more improvements
LHBruneton-C2C Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../src/lib/components/record-form/form-field/form-field-rich/form-field-rich.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
<span
class="material-symbols-outlined gn-ui-icon-small"
[ngClass]="{ 'text-primary': !preview }"
>{{ preview ? 'visibility' : 'visibility_off' }}</span
>{{ preview ? 'visibility_off' : 'visibility' }}</span
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that intentional? I haven't noticed that this was inverted

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is intentional. We kind of got used to it this way, but I felt it was wrong the first time I coded it. And now with François fresh view on it, it felt odd too.

>
&nbsp;
{{ preview ? 'WYSIWYG' : 'Markdown' }}
{{ preview ? 'Edit' : 'Preview' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks inverted as well? I thought preview meant the text was rendered properly without being editable

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, it was intentional. The button shows what you can do (action), not the current state.

</gn-ui-button>
<gn-ui-markdown-editor
[preview]="preview"
Expand Down
8 changes: 4 additions & 4 deletions libs/feature/editor/src/lib/fields.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,10 +256,10 @@ export const DATA_MANAGERS_SECTION: EditorSection = {
fields: [CONTACTS_FOR_RESOURCE_FIELD],
}

export const DATA_POINT_OF_CONTACT_SECTION: EditorSection = {
labelKey: marker('editor.record.form.section.dataPointOfContact.label'),
export const METADATA_POINT_OF_CONTACT_SECTION: EditorSection = {
labelKey: marker('editor.record.form.section.metadataPointOfContact.label'),
descriptionKey: marker(
'editor.record.form.section.dataPointOfContact.description'
'editor.record.form.section.metadataPointOfContact.description'
),
hidden: false,
fields: [CONTACTS],
Expand All @@ -285,7 +285,7 @@ export const DEFAULT_CONFIGURATION: EditorConfig = {
CLASSIFICATION_SECTION,
USE_AND_ACCESS_CONDITIONS_SECTION,
DATA_MANAGERS_SECTION,
DATA_POINT_OF_CONTACT_SECTION,
METADATA_POINT_OF_CONTACT_SECTION,
],
},
],
Expand Down
4 changes: 2 additions & 2 deletions libs/ui/search/src/lib/results-table/results-table.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
(sortChange)="setSortBy('recordOwner', $event)"
>
<ng-template #header>
<span translate>record.metadata.author</span>
<span translate>search.filters.user</span>
</ng-template>
<ng-template #cell let-item>
<ng-icon name="iconoirUser" size="16px"></ng-icon>
Expand Down Expand Up @@ -119,7 +119,7 @@
(sortChange)="setSortBy('changeDate', $event)"
>
<ng-template #header>
<span translate>record.metadata.updatedOn</span>
<span translate>search.filters.changeDate</span>
</ng-template>
<ng-template #cell let-item>
<div class="flex text-left w-full text-xs">
Expand Down
5 changes: 2 additions & 3 deletions translations/de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,9 @@
"editor.record.form.section.classification.label": "",
"editor.record.form.section.dataManagers.description": "",
"editor.record.form.section.dataManagers.label": "",
"editor.record.form.section.dataPointOfContact.description": "",
"editor.record.form.section.dataPointOfContact.label": "",
"editor.record.form.section.geographicalCoverage.label": "",
"editor.record.form.section.metadataPointOfContact.description": "",
"editor.record.form.section.metadataPointOfContact.label": "",
"editor.record.form.section.useAndAccessConditions.label": "",
"editor.record.form.temporalExtents.addDate": "Zeitpunkt",
"editor.record.form.temporalExtents.addRange": "Zeitraum",
Expand Down Expand Up @@ -416,7 +416,6 @@
"record.metadata.api.form.reset": "Zurücksetzen",
"record.metadata.api.form.title": "Benutzerdefinierte URL generieren",
"record.metadata.api.form.type": "Ausgabeformat",
"record.metadata.author": "Bearbeitet von",
"record.metadata.catalog": "Katalog",
"record.metadata.contact": "Kontakt",
"record.metadata.creation": "Erstellungsdatum",
Expand Down
129 changes: 64 additions & 65 deletions translations/en.json
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions translations/es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,9 @@
"editor.record.form.section.classification.label": "",
"editor.record.form.section.dataManagers.description": "",
"editor.record.form.section.dataManagers.label": "",
"editor.record.form.section.dataPointOfContact.description": "",
"editor.record.form.section.dataPointOfContact.label": "",
"editor.record.form.section.geographicalCoverage.label": "",
"editor.record.form.section.metadataPointOfContact.description": "",
"editor.record.form.section.metadataPointOfContact.label": "",
"editor.record.form.section.useAndAccessConditions.label": "",
"editor.record.form.temporalExtents.addDate": "",
"editor.record.form.temporalExtents.addRange": "",
Expand Down Expand Up @@ -416,7 +416,6 @@
"record.metadata.api.form.reset": "",
"record.metadata.api.form.title": "",
"record.metadata.api.form.type": "",
"record.metadata.author": "",
"record.metadata.catalog": "",
"record.metadata.contact": "",
"record.metadata.creation": "",
Expand Down
119 changes: 59 additions & 60 deletions translations/fr.json
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions translations/it.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,9 @@
"editor.record.form.section.classification.label": "",
"editor.record.form.section.dataManagers.description": "",
"editor.record.form.section.dataManagers.label": "",
"editor.record.form.section.dataPointOfContact.description": "",
"editor.record.form.section.dataPointOfContact.label": "",
"editor.record.form.section.geographicalCoverage.label": "",
"editor.record.form.section.metadataPointOfContact.description": "",
"editor.record.form.section.metadataPointOfContact.label": "",
"editor.record.form.section.useAndAccessConditions.label": "",
"editor.record.form.temporalExtents.addDate": "",
"editor.record.form.temporalExtents.addRange": "",
Expand Down Expand Up @@ -416,7 +416,6 @@
"record.metadata.api.form.reset": "Reset",
"record.metadata.api.form.title": "Genera un URL personalizzata",
"record.metadata.api.form.type": "Formato in uscita",
"record.metadata.author": "Modificato da",
"record.metadata.catalog": "Catalogo",
"record.metadata.contact": "Contatto",
"record.metadata.creation": "Data di creazione",
Expand Down
5 changes: 2 additions & 3 deletions translations/nl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,9 @@
"editor.record.form.section.classification.label": "",
"editor.record.form.section.dataManagers.description": "",
"editor.record.form.section.dataManagers.label": "",
"editor.record.form.section.dataPointOfContact.description": "",
"editor.record.form.section.dataPointOfContact.label": "",
"editor.record.form.section.geographicalCoverage.label": "",
"editor.record.form.section.metadataPointOfContact.description": "",
"editor.record.form.section.metadataPointOfContact.label": "",
"editor.record.form.section.useAndAccessConditions.label": "",
"editor.record.form.temporalExtents.addDate": "",
"editor.record.form.temporalExtents.addRange": "",
Expand Down Expand Up @@ -416,7 +416,6 @@
"record.metadata.api.form.reset": "",
"record.metadata.api.form.title": "",
"record.metadata.api.form.type": "",
"record.metadata.author": "",
"record.metadata.catalog": "",
"record.metadata.contact": "",
"record.metadata.creation": "",
Expand Down
5 changes: 2 additions & 3 deletions translations/pt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,9 @@
"editor.record.form.section.classification.label": "",
"editor.record.form.section.dataManagers.description": "",
"editor.record.form.section.dataManagers.label": "",
"editor.record.form.section.dataPointOfContact.description": "",
"editor.record.form.section.dataPointOfContact.label": "",
"editor.record.form.section.geographicalCoverage.label": "",
"editor.record.form.section.metadataPointOfContact.description": "",
"editor.record.form.section.metadataPointOfContact.label": "",
"editor.record.form.section.useAndAccessConditions.label": "",
"editor.record.form.temporalExtents.addDate": "",
"editor.record.form.temporalExtents.addRange": "",
Expand Down Expand Up @@ -416,7 +416,6 @@
"record.metadata.api.form.reset": "",
"record.metadata.api.form.title": "",
"record.metadata.api.form.type": "",
"record.metadata.author": "",
"record.metadata.catalog": "",
"record.metadata.contact": "",
"record.metadata.creation": "",
Expand Down
5 changes: 2 additions & 3 deletions translations/sk.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,9 @@
"editor.record.form.section.classification.label": "",
"editor.record.form.section.dataManagers.description": "",
"editor.record.form.section.dataManagers.label": "",
"editor.record.form.section.dataPointOfContact.description": "",
"editor.record.form.section.dataPointOfContact.label": "",
"editor.record.form.section.geographicalCoverage.label": "",
"editor.record.form.section.metadataPointOfContact.description": "",
"editor.record.form.section.metadataPointOfContact.label": "",
"editor.record.form.section.useAndAccessConditions.label": "",
"editor.record.form.temporalExtents.addDate": "",
"editor.record.form.temporalExtents.addRange": "",
Expand Down Expand Up @@ -416,7 +416,6 @@
"record.metadata.api.form.reset": "Resetovať",
"record.metadata.api.form.title": "Vytvoriť vlatnú URL",
"record.metadata.api.form.type": "Výstupný formát",
"record.metadata.author": "Autor",
"record.metadata.catalog": "Katalóg",
"record.metadata.contact": "Kontakt",
"record.metadata.creation": "",
Expand Down
Loading