Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e(me): apply label changes to the e2e tests #1096

Merged
merged 2 commits into from
Jan 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/datahub-e2e/cypress.config.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { defineConfig } from 'cypress'
import { nxE2EPreset } from '@nx/cypress/plugins/cypress-preset'
import { nxE2EPreset } from '@nx/cypress/plugins/cypress-preset.js'
import { cypressBrowserPermissionsPlugin } from 'cypress-browser-permissions'
import { fileURLToPath } from 'url'
import { configureCommonPlugins } from '../../tools/e2e/plugins.js'
Expand Down
4 changes: 2 additions & 2 deletions apps/metadata-editor-e2e/cypress.config.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { defineConfig } from 'cypress'
import { nxE2EPreset } from '@nx/cypress/plugins/cypress-preset'
import { configureCommonPlugins } from '../../tools/e2e/plugins'
import { nxE2EPreset } from '@nx/cypress/plugins/cypress-preset.js'
import { configureCommonPlugins } from '../../tools/e2e/plugins.js'
import { cypressBrowserPermissionsPlugin } from 'cypress-browser-permissions'
import { fileURLToPath } from 'url'

Expand Down
6 changes: 3 additions & 3 deletions apps/metadata-editor-e2e/src/e2e/dashboard.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ describe('dashboard (authenticated)', () => {
cy.get('gn-ui-search-filters-summary')
.find('[data-cy="filterSummaryLabel"]')
.invoke('text')
.should('eq', 'Modified by: ')
.should('eq', 'Editor: ')
})
it('should display the badge for a selected user', () => {
cy.get('gn-ui-search-filters-summary')
Expand Down Expand Up @@ -442,7 +442,7 @@ describe('dashboard (authenticated)', () => {
cy.get('gn-ui-search-filters-summary')
.find('[data-cy="filterSummaryLabel"]')
.invoke('text')
.should('eq', 'Modified on: ')
.should('eq', 'Updated: ')
})
it('should display the badge for the selected date range', () => {
cy.get('gn-ui-search-filters-summary')
Expand Down Expand Up @@ -498,7 +498,7 @@ describe('dashboard (authenticated)', () => {
cy.get('gn-ui-search-filters-summary')
.find('[data-cy="filterSummaryLabel"]')
.invoke('text')
.should('eq', 'Modified on: ')
.should('eq', 'Updated: ')
})
it('should display the badge for the selected date range', () => {
cy.get('gn-ui-search-filters-summary')
Expand Down
6 changes: 3 additions & 3 deletions apps/metadata-editor-e2e/src/e2e/record-actions.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ describe('record-actions', () => {
.find('[data-test="disabled-message"]')
.should(
'contain.text',
' This field will be enabled once the data has been published '
' This field will be enabled once the dataset has been published '
)

// second page
Expand All @@ -145,7 +145,7 @@ describe('record-actions', () => {
.find('div')
.should(
'contain.text',
' This field will be enabled once the data has been published '
' This field will be enabled once the dataset has been published '
)

cy.get('gn-ui-form-field-online-link-resources')
Expand All @@ -156,7 +156,7 @@ describe('record-actions', () => {
.find('div')
.should(
'contain.text',
' This field will be enabled once the data has been published '
' This field will be enabled once the dataset has been published '
)
})

Expand Down
2 changes: 1 addition & 1 deletion tools/e2e/plugins.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { VIEWPORT_SIZE } from './settings'
import { VIEWPORT_SIZE } from './settings.js'

export function configureCommonPlugins(on, config) {
on('before:browser:launch', (browser, launchOptions) => {
Expand Down
Loading