Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEL]: Make preview source selector optional #1119

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Feb 13, 2025

Description

This PR makes the source selector for the preview (map & data) optional.
This does not change anything in generic gn-ui visually, but will allow the MEL instance to hide the selector once the latest version is upgraded there. If the external viewer is not present, the space automatically collapses.
Note that this could have been done directly in MEL but this feature could be used by other instances on gn-ui in the future.

Architectural changes

none

Screenshots

no UI changes in gn-ui

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by MEL.

Copy link
Contributor

Affected libs: feature-record,
Affected apps: metadata-editor,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Feb 13, 2025

📷 Screenshots are here!

Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmoinier !

@cmoinier cmoinier merged commit 9237c52 into main Feb 13, 2025
12 checks passed
@cmoinier cmoinier deleted the mel-source-selector-optional branch February 13, 2025 11:46
@coveralls
Copy link

Coverage Status

coverage: 84.216%. first build
when pulling 063c1e4 on mel-source-selector-optional
into f9b0474 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants