Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webcomponents] : Full text search #1122

Merged
merged 5 commits into from
Mar 2, 2025
Merged

[Webcomponents] : Full text search #1122

merged 5 commits into from
Mar 2, 2025

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Feb 18, 2025

Description

This PR makes numerous fixes on the gn-search-input webcomponent.

  • Placeholder is now an Input to avoid having an empty value
  • White background for dropdown
  • Fixed space between input and dropdown
  • Fixed results-list implementation in gn-search-input-and-results
  • Ported various fixes from geocat
  • Added cache cleaning in build script because changes are not always taken into account
  • Added e2e component testing --> WONT DO

Architectural changes

none

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Feb 18, 2025

Affected libs: api-repository,
Affected apps: webcomponents,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Feb 18, 2025

📷 Screenshots are here!

@cmoinier cmoinier force-pushed the wc-full-text-search branch from 91cced1 to 6525bb0 Compare February 21, 2025 10:16
@cmoinier cmoinier force-pushed the wc-full-text-search branch 2 times, most recently from caacc5e to b877308 Compare February 24, 2025 13:32
Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes @cmoinier ! This mainly looks good to me.

Regarding the e2e tests, I think the webcomponents-e2e app only displays the list as it misses the "preparation" steps. The webcomponents app actually behaves the same way. Maybe we can solve the issue by generating a demo-e2e app? Which command did you use to generate the webcomponents-e2e one?

@cmoinier
Copy link
Collaborator Author

cmoinier commented Feb 26, 2025

Thanks for the fixes @cmoinier ! This mainly looks good to me.

Regarding the e2e tests, I think the webcomponents-e2e app only displays the list as it misses the "preparation" steps. The webcomponents app actually behaves the same way. Maybe we can solve the issue by generating a demo-e2e app? Which command did you use to generate the webcomponents-e2e one?

Thanks for the review! I think you are right with the 'demo-e2e' app idea. I did copy/pasted the datahub-e2e app for this work, because the cypress commands were adding a general cypress app and not a dedicated webcomponents one. I think I can easily switch the config from wc app to the demo app, I will try that now :)

EDIT : I did try (see commit), and it doesn't work much better, the list is still displayed...

@cmoinier cmoinier force-pushed the wc-full-text-search branch from b877308 to 1a7bc01 Compare February 26, 2025 19:25
Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adaptions @cmoinier ! I'll approve partially apart from the e2e tests that I've not gotten to work yet neither. Maybe we can push them to a separate branch for now.

@cmoinier cmoinier force-pushed the wc-full-text-search branch from 9a8929f to 4170b12 Compare February 28, 2025 09:29
@coveralls
Copy link

Coverage Status

coverage: 84.348% (-0.5%) from 84.811%
when pulling 5c156c0 on wc-full-text-search
into bd37f68 on main.

@cmoinier cmoinier merged commit 22c177e into main Mar 2, 2025
125 of 140 checks passed
@cmoinier cmoinier deleted the wc-full-text-search branch March 2, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants