Fix: missing glyphs with multiple unicodes #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For glyphs with multiple unicodes, some of them wouldn't be included in the generated json file, which leads to the characters missing issue when the json is loaded in Three.js.
This pull request is created for fixing it in a non-breaking way.
Motivation and Context
Among non-latin characters, some of them are bound to multiple unicodes, but when the character is decoded in javascript runtime, only one of the unicode would be decoded.
Here's a screenshot for better explanation.
Here's a related unresolved issue. #25
Here's an open PR attempting to solve the same issue. #22
How Has This Been Tested?
Here's the link of the fixed version. https://shuaibird.github.io/facetype.js/
A font file with the character
心
is uploaded in both the original version (A) & the forked version (B).心
in Three.js, only the json downloaded from B succeeds.心
, check the generated files, only the json downloaded from B contains the心
glyph.Types of Changes
Checklist: