Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use html5 writer from docutils #3432

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use html5 writer from docutils #3432

wants to merge 1 commit into from

Conversation

nkr0
Copy link

@nkr0 nkr0 commented Dec 2, 2024 •
edited
Loading

Pull Request Checklist

Resolves: #3004

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

@nkr0 nkr0 mentioned this pull request Dec 2, 2024
Open
3 tasks
@justinmayer justinmayer added this to the Pelican 5.0 milestone Dec 2, 2024
pauloxnet
pauloxnet approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinmayer
Copy link
Member

As I mentioned in the linked issue, I suspect this change might be best introduced in the context of a major version, which is why I have targeted it for an upcoming 5.0 release. I hope to organize a sprint sometime soon so we can make that happen 😅

@nkr0
Copy link
Author

nkr0 commented Jan 31, 2025

As I mentioned in the linked issue, I suspect this change might be best introduced in the context of a major version, which is why I have targeted it for an upcoming 5.0 release. I hope to organize a sprint sometime soon so we can make that happen 😅

Yes, I remember. I did a rebase yesterday to fix a build failure after merging main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauloxnet pauloxnet pauloxnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Pelican 5.0
Development

Successfully merging this pull request may close these issues.

Switch to Docutils HTML5 writer instead of the HTML4 one
3 participants
@nkr0 @justinmayer @pauloxnet