Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: 200-399 HTTP status has log level info #4879

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Feb 20, 2025

Add tests to validate that 200-399 HTTP status codes return the log level info for crumbs, as pointed out in the develop docs: https://develop.sentry.dev/sdk/expected-features/#http-client-integrations.

Follow up on GH-4779, came up in getsentry/team-sdks#100 (comment).

#skip-changelog

Add tests to validate that 200-399 HTTP status codes return the log level
info for crumbs, as pointed out in the develop docs:
https://develop.sentry.dev/sdk/expected-features/#http-client-integrations.
@philipphofmann philipphofmann force-pushed the test/crumb-http-status-codes branch from 5d94658 to fed6924 Compare February 20, 2025 15:43
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.247%. Comparing base (9ef38ea) to head (fed6924).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4879       +/-   ##
=============================================
- Coverage   92.257%   92.247%   -0.011%     
=============================================
  Files          659       659               
  Lines        77328     77382       +54     
  Branches     27945     27965       +20     
=============================================
+ Hits         71341     71383       +42     
- Misses        5891      5899        +8     
- Partials        96       100        +4     
Files with missing lines Coverage Δ
...erformance/Network/SentryNetworkTrackerTests.swift 99.070% <100.000%> (+0.044%) ⬆️

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ef38ea...fed6924. Read the comment docs.

@philipphofmann philipphofmann merged commit 3b083c5 into main Feb 21, 2025
50 of 52 checks passed
@philipphofmann philipphofmann deleted the test/crumb-http-status-codes branch February 21, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants