Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] Enable JS SDK native integration by default #2688

Merged
merged 10 commits into from
Feb 14, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Feb 10, 2025

📜 Description

💡 Motivation and Context

Closes #2634

💚 How did you test it?

Existing tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@buenaflor buenaflor changed the base branch from main to v9 February 10, 2025 23:38
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.24%. Comparing base (5ce593b) to head (d7ce527).
Report is 1 commits behind head on v9.

Files with missing lines Patch % Lines
flutter/lib/src/sentry_flutter.dart 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v9    #2688      +/-   ##
==========================================
- Coverage   88.31%   88.24%   -0.07%     
==========================================
  Files         262      263       +1     
  Lines        8911     8918       +7     
==========================================
  Hits         7870     7870              
- Misses       1041     1048       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor marked this pull request as ready for review February 12, 2025 15:06
@buenaflor buenaflor requested a review from denrase February 13, 2025 15:13
Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still access options.enableSentryJs = true; in the tests

@@ -165,7 +164,6 @@ void main() {
testWidgets('Sentry JS SDK is not initialized', (tester) async {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need this test, as we always enable by default? If not, we can also remove the enabled group.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depends, this specifically tests that if autoInitializeNativeSdks = false then we won't init the SDK

I forgot the autoInitializeNativeSdks = false

@buenaflor buenaflor merged commit ea071ab into v9 Feb 14, 2025
153 checks passed
@buenaflor buenaflor deleted the v9-feat/enable-js-native-by-default branch February 14, 2025 11:01
@vaind vaind mentioned this pull request Feb 18, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dart/Flutter]: v9 Main Tasks
2 participants