-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v9] Enable JS SDK native integration by default #2688
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v9 #2688 +/- ##
==========================================
- Coverage 88.31% 88.24% -0.07%
==========================================
Files 262 263 +1
Lines 8911 8918 +7
==========================================
Hits 7870 7870
- Misses 1041 1048 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still access options.enableSentryJs = true;
in the tests
@@ -165,7 +164,6 @@ void main() { | |||
testWidgets('Sentry JS SDK is not initialized', (tester) async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we even need this test, as we always enable by default? If not, we can also remove the enabled
group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depends, this specifically tests that if autoInitializeNativeSdks = false
then we won't init the SDK
I forgot the autoInitializeNativeSdks = false
📜 Description
💡 Motivation and Context
Closes #2634
💚 How did you test it?
Existing tests
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps