Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dynamic-sampling): organization settings #11791
feat(dynamic-sampling): organization settings #11791
Changes from 7 commits
714bbef
4092b56
cf6ed25
c9eab8e
0559a31
778beb6
c73f242
3a07833
a872516
aa9d35c
0405349
a1a33fb
4795538
797efb9
d5cae09
1b212fc
70990f8
11ba516
be109c7
6e2c87e
aba7b8b
f334b04
3c7a5c6
df915d9
8307844
81e1f08
8aa5890
60ac005
0dc606b
45ad919
5550bb0
704ab13
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call out that on AM2 there's also DS, the sample rate is chosen by the system based on transaction volume (1M+), and you still have controls for the sampling priorities?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking, "never" isn't true :)
traces_sampler
allows customers to write their own code for dynamically adjusting sample rates. I think the true differences can rather be summarized as:traces_sample_rate
ortraces_sampler
callback, which usually requires a new deployment or release.