feat(dynamic-sampling): adapt docs to new dynamic sampling logic #11886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
jan-auer
reviewed
Nov 22, 2024
There was a problem hiding this comment.
Is there a place where you're planning to describe the newly introduced organization and project options? I also noticed that the biases don't describe how their behavior is different in the two modes. The most notable differences are:
- Boost low volume projects is disabled in manual mode
- Boost low volume transactions uses the sample rate from the project option
- All other biases compute factors that are independent of the sample rate
- Recalibration switches to project level
develop-docs/application-architecture/dynamic-sampling/fidelity-and-biases.mdx
Outdated
Show resolved
Hide resolved
develop-docs/application-architecture/dynamic-sampling/fidelity-and-biases.mdx
Outdated
Show resolved
Hide resolved
develop-docs/application-architecture/dynamic-sampling/fidelity-and-biases.mdx
Outdated
Show resolved
Hide resolved
|
|
||
| The latest release bias uses a decaying rule to interpolate between a starting sample rate and an ending sample rate over a time window that is statically defined for each platform (the list of time to adoptions is define [here](https://github.com/getsentry/sentry/blob/master/src/sentry/dynamic_sampling/rules/helpers/time_to_adoptions.py#L26-L26). For example, Android has a bigger time window than Javascript because on average Android apps take more time to get adopted by users. | ||
| In order to rebalance transactions, the system computes the counts of the transactions for each project and runs an algorithm that, given the sample rate of the organization and the counts of each transaction, computes a new sample rate for each transaction assuming an ideal distribution of the counts. |
There was a problem hiding this comment.
In a recent conversation, you brought up that it is surprising how the algorithm tries to achieve an equal sample count for each "class" (as it is called in code). This could be considered an implementation detail, but I think it's worth writing this down as the desired behavior of the system at this time.
develop-docs/application-architecture/dynamic-sampling/the-big-picture.mdx
Outdated
Show resolved
Hide resolved
develop-docs/application-architecture/dynamic-sampling/the-big-picture.mdx
Outdated
Show resolved
Hide resolved
develop-docs/application-architecture/dynamic-sampling/the-big-picture.mdx
Outdated
Show resolved
Hide resolved
jan-auer
approved these changes
Nov 26, 2024
martinhaintz
pushed a commit
that referenced
this pull request
Nov 27, 2024
…ierarchy * master: (28 commits) feat(angular): Update SDK provider setup for Angular 19 (#11921) feat(dynamic-sampling): adapt docs to new dynamic sampling logic (#11886) update banner for post-launch week promotion (#11964) chore(android): Add masking options to AndroidManifest (#11863) Bump API schema to 2126f7dd (#11965) chore(Profiling): Add callouts and links to Android Profiling troubleshooting info (#11905) docs(flutter): Use sentry flutter init in samples (#11858) use native crypto to generate uuid (#11959) fix vercel integration 404 (#11958) Add RN Replay Privacy page (#11798) feat(dashboards): Add docs for Dashboard Edit Access Selector (#11822) feat(app-starts): Add RN SDK min version (#11650) feat(realy): Add Relay best practices guide (#11914) docs(sdks): New Scope APIs (#11943) docs(sdks): Span Sampling (#11940) Add include explaining sample code options (#11866) devenv: internal troubleshooting (#11947) Bump API schema to 0b18bfae (#11946) Bump API schema to 2bee5317 (#11945) feat: Link to Replay Issues when we mention Perf Issues as well (#11933) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the documentation for dynamic sampling to reflect the new status quo:
transactionfor the event description, we useeventsto encompass both transactions and spans.