Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free docs from @sentry/types #11988

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Free docs from @sentry/types #11988

merged 2 commits into from
Nov 28, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Nov 28, 2024

DESCRIBE YOUR PR

Ref: getsentry/sentry-javascript#14271

Removes all references to @sentry/types.

  • We will remove @sentry/types in the next major so using it is discouraged.
  • Having to use it is an anti-pattern in our world.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 2:06pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 2:06pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 2:06pm

@lforst lforst requested review from mydea and chargome November 28, 2024 13:39
Copy link

codecov bot commented Nov 28, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.2MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.11MB 6 bytes (-0.0%) ⬇️

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lforst lforst merged commit 14f6fbb into master Nov 28, 2024
11 checks passed
@lforst lforst deleted the lforst-no-sentry-types branch November 28, 2024 14:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants