Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(android): rename Apollo 2 to mention version and update callout #12730

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lcian
Copy link
Member

@lcian lcian commented Feb 14, 2025

DESCRIBE YOUR PR

Updates "Apollo" to be renamed to "Apollo 2" to avoid confusion as we already have "Apollo 3" and soon we will have "Apollo 4".
Also updates the callout about the versions to point to the upcoming "Apollo 4" docs pages.
Comes after #12729

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 4:33pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 4:33pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 4:33pm

Copy link

codecov bot commented Feb 14, 2025

Bundle Report

Changes will decrease total bundle size by 9 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.93MB -3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%
../app/[[...path]]/page.js.nft.json 2 bytes 376.06kB 0.0%
../app/platform-redirect/page.js.nft.json 2 bytes 375.97kB 0.0%
../app/sitemap.xml/route.js.nft.json 2 bytes 373.94kB 0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
static/H1s0dJdK9vO0KdoiclZEB/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/H1s0dJdK9vO0KdoiclZEB/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/UzfSDbggriopW1jPxIfj-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/UzfSDbggriopW1jPxIfj-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️

@lcian lcian requested review from adinauer and markushi February 26, 2025 15:02
@lcian lcian marked this pull request as ready for review February 26, 2025 15:03
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants