-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap up continuous profiling #4069
Merged
stefanosiano
merged 6 commits into
feat/continuous-profiling-part1
from
feat/continuous-profiling-wrapup
Feb 14, 2025
Merged
Wrap up continuous profiling #4069
stefanosiano
merged 6 commits into
feat/continuous-profiling-part1
from
feat/continuous-profiling-wrapup
Feb 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
7 tasks
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a82f345 | 497.67 ms | 603.94 ms | 106.27 ms |
79f2c66 | 409.12 ms | 460.06 ms | 50.94 ms |
584f250 | 411.35 ms | 428.56 ms | 17.21 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a82f345 | 1.65 MiB | 2.31 MiB | 681.47 KiB |
79f2c66 | 1.65 MiB | 2.31 MiB | 681.47 KiB |
584f250 | 1.65 MiB | 2.31 MiB | 681.50 KiB |
romtsn
reviewed
Feb 14, 2025
romtsn
reviewed
Feb 14, 2025
romtsn
approved these changes
Feb 14, 2025
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
87bdd6d
into
feat/continuous-profiling-part1
27 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Last changes in order to have working continuous profiling on Android.
Notable change: chunk duration is now increased to 60 seconds
There is still a frontend fix that needs to be deployed before testing it out completely
#skip-changelog
💡 Motivation and Context
Last part of #3710
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps