Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sampleRate in DSC #4158

Merged
merged 31 commits into from
Feb 12, 2025
Merged

Update sampleRate in DSC #4158

merged 31 commits into from
Feb 12, 2025

Conversation

adinauer
Copy link
Member

📜 Description

Whenever tracesSampleRate or tracesSampler callback or manually setting a sampling decision happen, we want to update the sampleRate in DSC to have it reflect what was actually used.

💡 Motivation and Context

Closes #4116

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 715eef8

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 498.06 ms 609.19 ms 111.13 ms
Size 1.58 MiB 2.21 MiB 641.10 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c2c78de 415.28 ms 505.08 ms 89.80 ms

App size

Revision Plain With Sentry Diff
c2c78de 1.58 MiB 2.21 MiB 640.27 KiB

Previous results on branch: feat/update-dsc-sample-rate

Startup times

Revision Plain With Sentry Diff
7adf69b 492.39 ms 503.90 ms 11.51 ms

App size

Revision Plain With Sentry Diff
7adf69b 1.58 MiB 2.21 MiB 640.93 KiB

Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from feat/sample_rand to main February 12, 2025 16:50
@adinauer adinauer merged commit 80eda8c into main Feb 12, 2025
35 checks passed
@adinauer adinauer deleted the feat/update-dsc-sample-rate branch February 12, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java SDK Update DSC sample-rate
4 participants