Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options.tracePropagationTargets should not be internal #4170

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

adinauer
Copy link
Member

Remove internal annotation

📜 Description

💡 Motivation and Context

Since this is a documented option it shouldn't be marked internal.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 332.37 ms 410.67 ms 78.30 ms
Size 1.58 MiB 2.21 MiB 641.10 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c2c78de 415.28 ms 505.08 ms 89.80 ms

App size

Revision Plain With Sentry Diff
c2c78de 1.58 MiB 2.21 MiB 640.27 KiB

@adinauer adinauer merged commit f0eb0a2 into main Feb 17, 2025
35 checks passed
@adinauer adinauer deleted the fix/trace-prop-targets-not-internal branch February 17, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants