Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention ip-address change in 7.21.0 changelog as well #4174

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Mention ip-address change in 7.21.0 changelog as well #4174

merged 2 commits into from
Feb 17, 2025

Conversation

markushi
Copy link
Member

#skip-changelog

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

kahest
kahest approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor change

@markushi @kahest
Update CHANGELOG.md
ec363cd 
Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
@markushi markushi enabled auto-merge (squash) February 17, 2025 16:48
@markushi markushi merged commit cf3d1e2 into main Feb 17, 2025
31 of 32 checks passed
@markushi markushi deleted the markushi/chore/update-changelog branch February 17, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kahest kahest kahest approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@lcian lcian Awaiting requested review from lcian lcian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markushi @kahest