Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ignoredErrors option in manifest #4178

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented Feb 18, 2025

📜 Description

Add support for ignoredErrors option in Manifest.

💡 Motivation and Context

Closes #4126

💚 How did you test it?

Unit tests

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Feb 18, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f3b94b8

@lcian lcian changed the title Add support for ignoredErrors option in Manifest Add support for ignoredErrors option in manifest Feb 18, 2025
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 398.40 ms 485.27 ms 86.87 ms
Size 1.58 MiB 2.21 MiB 641.07 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c2c78de 415.28 ms 505.08 ms 89.80 ms

App size

Revision Plain With Sentry Diff
c2c78de 1.58 MiB 2.21 MiB 640.27 KiB

Previous results on branch: feat/ignored-errors-manifest

Startup times

Revision Plain With Sentry Diff
b7b1e51 361.58 ms 426.38 ms 64.80 ms

App size

Revision Plain With Sentry Diff
b7b1e51 1.58 MiB 2.21 MiB 641.08 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcian lcian enabled auto-merge (squash) February 20, 2025 07:57
@lcian lcian merged commit 4c80d9e into main Feb 20, 2025
33 checks passed
@lcian lcian deleted the feat/ignored-errors-manifest branch February 20, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ignoredErrors in Manifest metadata
3 participants