Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constructor to JUL SentryHandler for disabling external config #4208

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

adinauer
Copy link
Member

📜 Description

Add another constructor to SentryHandler that allows passing enableExternalConfiguration to disable parsing of external configuration (by passing false). This defaults to true when using other constructors.

💡 Motivation and Context

Came up in #4205 where Quarkus is trying to disable parsing of external config like sentry.properties or ENV vars.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Feb 25, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 05de50f

Copy link
Contributor

github-actions bot commented Feb 25, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 422.54 ms 468.63 ms 46.09 ms
Size 1.58 MiB 2.21 MiB 641.65 KiB

Previous results on branch: feat/jul-ctor-external-options

Startup times

Revision Plain With Sentry Diff
eab3927 394.20 ms 447.68 ms 53.48 ms

App size

Revision Plain With Sentry Diff
eab3927 1.58 MiB 2.21 MiB 641.59 KiB

@adinauer adinauer mentioned this pull request Feb 26, 2025
@adinauer adinauer merged commit cde02ad into main Feb 26, 2025
34 checks passed
@adinauer adinauer deleted the feat/jul-ctor-external-options branch February 26, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants