ref(flags): remove FeatureFlagContext type export #14646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
previously approved these changes
Dec 10, 2024
billyvg
reviewed
Dec 10, 2024
| @@ -19,6 +19,7 @@ export type { | |||
| TraceContext, | |||
| CloudResourceContext, | |||
| MissingInstrumentationContext, | |||
| FeatureFlagContext, | |||
There was a problem hiding this comment.
🤔 Is this used anywhere in the SDK?
There was a problem hiding this comment.
It's used in the scope class I believe, scope.ts
There was a problem hiding this comment.
If not directly, then in the Contexts type.
|
Yeah I think this type won't be needed in sentry either after getsentry/sentry#81954 |
|
@aliu39 can we remove it completely since it's not used at all? |
aliu39
changed the title
|
@billyvg we still need it for the |
aliu39
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from getsentry/sentry#81925 (comment). Like the other context types this should be exported here. We're using it in sentry right now, but importing from /build.