Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename $callable to $callback #1683

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Rename $callable to $callback #1683

merged 1 commit into from
Jan 18, 2024

Conversation

cleptric
Copy link
Member

We call this parameter $callback on all other occurrences in the codebase.
Mainly doing it so named arguments stay consistent. It's not BC, but we haven't released #1670 yet.

@cleptric cleptric self-assigned this Jan 18, 2024
@cleptric cleptric requested a review from stayallive January 18, 2024 12:52
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good catch!

@cleptric cleptric enabled auto-merge (squash) January 18, 2024 12:56
@cleptric cleptric merged commit 1cc36e6 into master Jan 18, 2024
31 checks passed
@cleptric cleptric deleted the rename-pramater branch January 18, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants