Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle metric_bucket rate limits #1726

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Handle metric_bucket rate limits #1726

merged 2 commits into from
Apr 2, 2024

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Apr 2, 2024 •
edited
Loading

This adds handling rate limits for metrics.
The namespace will not be customizable from the SDK, hence we do not need to check for the namespace, as custom will always be inferred.

closes #1723

@cleptric cleptric requested a review from stayallive April 2, 2024 10:07
@cleptric cleptric self-assigned this Apr 2, 2024
stayallive
stayallive approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice, this was simpler than I anticipated. 💪

@cleptric cleptric merged commit 3c50e8b into master Apr 2, 2024
31 checks passed
@cleptric cleptric deleted the metric-ratelimits branch April 2, 2024 11:12
This was referenced Apr 3, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

Assignees

@cleptric cleptric

Labels
Type: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metrics Rate Limits
2 participants
@cleptric @stayallive