Add fast path for ignoring errors #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the
ErrorHandleraware of the SDK options in default operations and allows it to take a fast path and ignore errors without doing any work instead of building up a error exception and discarding it in theErrorListenerIntegration. If a lot of errors are being ignored this can end up saving a some time and wasted CPU cycles.This should be completely backwards compatible and if anyone uses the
ErrorHandlerdirectly they should not see any improvement nor any negative effect nor need to change their code. But if theErrorHandleris managed by the SDK it will becomeOptionsaware and allow to take the fast path.There are intentionally no tests since this change only should affect performance and has no effect on the outcome or operation of the SDK. Either
shouldHandleErroror the twoifcases in theErrorHandlercan be removed without any failing tests and having both also leaves all tests intact proving we still handle and ignore the same errors as before just with slightly improved performance now.Fixes #1736.