-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Test relevant prereleases and allow to ignore releases #4073
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4073 +/- ##
==========================================
- Coverage 79.54% 79.53% -0.01%
==========================================
Files 140 140
Lines 15512 15512
Branches 2628 2628
==========================================
- Hits 12339 12338 -1
Misses 2337 2337
- Partials 836 837 +1 |
Never mind, I found the answer: the reason for ignoring these releases is that Litestar replaced Starlite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one suggestion (marked [suggestion]) and two questions (marked [question]. The items marked [question] are mainly to improve my understanding and should not be considered requests to change anything, unless of course the question prompts you to want to change something.
I also have one potential concern here: what if a prerelease fails in testing due to a bug in the prerelease rather than a problem in the Sentry SDK? Would we just manually ignore these prereleases before merging the generated tox.ini
?
Exactly, we would need to add them to the |
@szokeasaurusrex fyi, I've changed |
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
If a package has a prerelease of a higher version than the highest released stable version, make sure to test it, too. We consider alpha, beta, and RC releases.
Also add an option to ignore specific releases (this is related to the above since the script now pulls in two irrelevant alpha releases of starlite).
Closes #4030