Skip to content

Commit

Permalink
chore(billing): Add metrics to queue assignment (#78074)
Browse files Browse the repository at this point in the history
Add some metrics to queue assignment added in
#75999
  • Loading branch information
dashed authored Sep 24, 2024
1 parent 4221105 commit 109d1e6
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/sentry/buffer/redis.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,9 @@ def queue(self, model_key: str) -> str | None:
"""
Get the queue name for the given model_key.
"""
metrics.incr(f"pendingbuffer-router.queue.{model_key}")
if model_key in self.pending_buffer_router:
metrics.incr(f"pendingbuffer-router.queue-found.{model_key}")
generate_queue = self.pending_buffer_router[model_key].generate_queue
if generate_queue is not None:
return generate_queue(model_key)
Expand Down Expand Up @@ -158,6 +160,7 @@ def assign_queue(self, model: type[models.Model], generate_queue: ChooseQueueFun
A queue can be assigned to a model by passing in the generate_queue function.
"""
key = _get_model_key(model=model)
metrics.incr(f"redisbuffer-router.assign_queue.{key}")
self._routers[key] = generate_queue

def create_pending_buffers_router(self, incr_batch_size: int) -> PendingBufferRouter:
Expand Down Expand Up @@ -526,7 +529,7 @@ def _generate_process_incr_kwargs(model_key: str | None) -> dict[str, Any]:
# model associated with the model_key.
process_incr_kwargs: dict[str, Any] = dict()
if model_key is None:
metrics.incr("buffer.process-incr.model-key-missing")
metrics.incr("buffer.process-incr.model-key-missing", tags={"model_key": model_key})
return process_incr_kwargs
queue = pending_buffers_router.queue(model_key=model_key)
if queue is not None:
Expand Down

0 comments on commit 109d1e6

Please sign in to comment.