Skip to content

Commit

Permalink
Fix typing stuff
Browse files Browse the repository at this point in the history
  • Loading branch information
MichaelSun48 committed Mar 5, 2025
1 parent c4583f5 commit 3bc04c8
Showing 1 changed file with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ def setUp(self) -> None:
self.base_data = self.create_base_data()

# Get the first view's ID for testing
self.view_id = str(self.base_data["user_one_views"][0].id)
self.view = self.base_data["user_one_views"][0]

self.url = reverse(
"sentry-api-0-organization-group-search-view-visit",
kwargs={"organization_id_or_slug": self.organization.slug, "view_id": self.view_id},
kwargs={"organization_id_or_slug": self.organization.slug, "view_id": self.view.id},
)

@freeze_time("2025-03-03 14:52:37")
Expand All @@ -30,7 +30,7 @@ def test_update_last_seen_success(self) -> None:
GroupSearchViewLastSeen.objects.filter(
organization=self.organization,
user_id=self.user.id,
group_search_view_id=self.view_id,
group_search_view=self.view,
).count()
== 0
)
Expand All @@ -42,7 +42,7 @@ def test_update_last_seen_success(self) -> None:
last_seen = GroupSearchViewLastSeen.objects.get(
organization=self.organization,
user_id=self.user.id,
group_search_view_id=self.view_id,
group_search_view=self.view,
)
assert last_seen.last_seen == timezone.now()

Expand All @@ -54,7 +54,7 @@ def test_update_existing_last_seen(self) -> None:
GroupSearchViewLastSeen.objects.create(
organization=self.organization,
user_id=self.user.id,
group_search_view_id=self.view_id,
group_search_view=self.view,
last_seen=timezone.now(),
)

Expand All @@ -66,7 +66,7 @@ def test_update_existing_last_seen(self) -> None:
last_seen = GroupSearchViewLastSeen.objects.get(
organization=self.organization,
user_id=self.user.id,
group_search_view_id=self.view_id,
group_search_view=self.view,
)
assert last_seen.last_seen == timezone.now()
assert last_seen.last_seen.year == 2025 # Verify it's the new timestamp
Expand All @@ -90,10 +90,10 @@ def test_update_nonexistent_view(self) -> None:
@with_feature({"organizations:issue-stream-custom-views": True})
def test_update_view_from_another_user(self) -> None:
# Get a view ID from user_two
view_id = str(self.base_data["user_two_views"][0].id)
view = self.base_data["user_two_views"][0]
url = reverse(
"sentry-api-0-organization-group-search-view-visit",
kwargs={"organization_id_or_slug": self.organization.slug, "view_id": view_id},
kwargs={"organization_id_or_slug": self.organization.slug, "view_id": view.id},
)

# This should succeed because the view exists in the organization
Expand All @@ -105,7 +105,7 @@ def test_update_view_from_another_user(self) -> None:
last_seen = GroupSearchViewLastSeen.objects.get(
organization=self.organization,
user_id=self.user.id,
group_search_view_id=view_id,
group_search_view=view,
)
assert last_seen is not None

Expand All @@ -117,5 +117,5 @@ def test_update_without_feature_flag(self) -> None:
assert not GroupSearchViewLastSeen.objects.filter(
organization=self.organization,
user_id=self.user.id,
group_search_view_id=self.view_id,
group_search_view=self.view,
).exists()

0 comments on commit 3bc04c8

Please sign in to comment.