feat: open source gsApp (revised) #85592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Bundle ReportChanges will increase total bundle size by 8.17MB (24.47%) ⬆️
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
Files in
Files in
Files in
Files in
Files in
Files in
|
Comment on lines
+88
to
+101
| const [{default: registerHooks}, {initializeBundleMetrics}] = await Promise.all([ | ||
| import('getsentry/registerHooks'), | ||
| import('getsentry/initializeBundleMetrics'), | ||
| ]); | ||
|
|
||
| // getsentry augments Sentry's application through a 'hook' mechanism. Sentry | ||
| // provides various hooks into parts of its application. Thus all getsentry | ||
| // functionality is initialized by registering its hook functions. | ||
| registerHooks(); | ||
|
|
||
| const {initializeMain} = await initalizeMainImport; | ||
| initializeMain(config); | ||
|
|
||
| initializeBundleMetrics(); |
There was a problem hiding this comment.
you can reorder this so the initalizeBundleMetrics can keep resolving while calling registerhooks
Suggested change
| const [{default: registerHooks}, {initializeBundleMetrics}] = await Promise.all([ | |
| import('getsentry/registerHooks'), | |
| import('getsentry/initializeBundleMetrics'), | |
| ]); | |
| // getsentry augments Sentry's application through a 'hook' mechanism. Sentry | |
| // provides various hooks into parts of its application. Thus all getsentry | |
| // functionality is initialized by registering its hook functions. | |
| registerHooks(); | |
| const {initializeMain} = await initalizeMainImport; | |
| initializeMain(config); | |
| initializeBundleMetrics(); | |
| const registerHooksImport = import('getsentry/registerHooks'); | |
| const initalizeBundleMetricsImport = import('getsentry/initializeBundleMetrics'); | |
| // getsentry augments Sentry's application through a 'hook' mechanism. Sentry | |
| // provides various hooks into parts of its application. Thus all getsentry | |
| // functionality is initialized by registering its hook functions. | |
| const {default: registerHooks} = await registerHooksImport; | |
| registerHooks(); | |
| const {initializeMain} = await initalizeMainImport; | |
| initializeMain(config); | |
| const {initializeBundleMetrics} = await initializeBundleMetricsImport; | |
| initializeBundleMetrics(); |
This way you're able to boot things faster
There was a problem hiding this comment.
I'll... address this as a folllowup
evanpurkhiser
approved these changes
Feb 27, 2025
(cherry picked from commit 08dc546)
|
I have waited for this, thank you 🥹 |
JonasBa
pushed a commit
that referenced
this pull request
Feb 27, 2025
This open sources gsApp. Getsentry will remain unaffected after this is merged, then getsentry/getsentry#16675 will remove gsApp in getsentry. Differences: - gsApp's entrypoint index.tsx is inlined into the main sentry app, and makes use of sentry mode (#80342) so that open source sentry will not initialize gsApp. - getsentry devserver will set sentryMode appropriately so that gsApp is initialized getsentry devserver is still needed to work on gsApp, even though it lives in sentry. Eventually it'll all (gsAdmin, jest/webpack/eslint configs) be moved/merged over.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
|
Is it possible to move (or did we consider moving) the history to Examples: CC: @joshuarli |
Erm, there's probably some sensitive info in git history, so you'll have to live with searching through it in getsentry for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This open sources gsApp. Getsentry will remain unaffected after this is merged, then https://github.com/getsentry/getsentry/pull/16675 will remove gsApp in getsentry.
Differences:
getsentry devserver is still needed to work on gsApp, even though it lives in sentry. Eventually it'll all (gsAdmin, jest/webpack/eslint configs) be moved/merged over.