Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(cleanup): use concurrency for fileblobs #85800

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

JoshFerge
Copy link
Member

@JoshFerge JoshFerge commented Feb 24, 2025

reopening #68556

  • adds new worker queue for deleting files which uses the concurrency setting
  • wait for both queues at end of job

tested the job runs successfully locally. we do not have tests on this functionality, so will have to be very careful and watch various dashboards when merging.

Copy link

sentry-io bot commented Feb 24, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/runner/commands/cleanup.py

Function Unhandled Issue
cleanup InterfaceError: connection already closed cleanup
Event Count: 40

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 24, 2025
@JoshFerge JoshFerge requested a review from mrduncan February 24, 2025 22:04
@JoshFerge JoshFerge merged commit aff5c96 into master Feb 26, 2025
53 checks passed
@JoshFerge JoshFerge deleted the jferg/parallel branch February 26, 2025 15:57
@JoshFerge JoshFerge added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Feb 26, 2025
@getsentry-bot
Copy link
Contributor

PR reverted: 92b8b3c

getsentry-bot added a commit that referenced this pull request Feb 26, 2025
This reverts commit aff5c96.

Co-authored-by: JoshFerge <1976777+JoshFerge@users.noreply.github.com>
@JoshFerge
Copy link
Member Author

reverting as deletion metrics looking effected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants