-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tours): Introduce a Tours API via hooks/context #85900
Conversation
48c9134
to
4b89586
Compare
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Bundle ReportChanges will increase total bundle size by 27.71kB (0.07%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
Files in
|
55f41eb
to
73b5b4f
Compare
ea49dc6
to
4c22522
Compare
deec519
to
92446f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is looking great! Thanks for being so quick to respond to all the feedback @leeandher 💯
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This PR introduces a system for building out in-product tours. It's a bit verbose, but I think it's fairly extensible and could be used elsewhere in the app, not just issue details.
Update: A lot of what I'd previously written had become outdated so I'd just check out the story book instead.
todo
tourContext.spec.tsx
components.spec.tsx