Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 Sanitize PagerDuty integration key and routing key by stripping whitespace and quotes #86010

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

🤖 Sanitize PagerDuty integration key and routing key by stripping whitespace and quotes #86010

wants to merge 3 commits into from

Conversation

sentry-autofix[bot]
Copy link
Contributor

👋 Hi there! This PR was automatically generated by Autofix 🤖

This fix was triggered by tillman.elser@sentry.io

Fixes SENTRY-3H3D

  • Added sanitization to the integration key during client initialization to remove leading/trailing whitespace and quotes.
  • Added sanitization to the routing key in the payload before sending to the PagerDuty API to remove leading/trailing whitespace and quotes.
  • Added tests to verify the sanitization of the integration key and routing key.

If you have any questions or feedback for the Sentry team about this fix, please email autofix@sentry.io with the Run ID: 6993.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 27, 2025
@trillville trillville added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Feb 27, 2025
@github-actions github-actions bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Feb 27, 2025
@trillville trillville added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Feb 27, 2025
@trillville trillville marked this pull request as ready for review February 27, 2025 04:26
@trillville trillville requested review from a team as code owners February 27, 2025 04:26
@iamrajjoshi
Copy link
Member

iamrajjoshi commented Feb 27, 2025 •
edited
Loading

almost correct, i would just strip the routing key. let me fix it up real quick.

though longer term, we should have a routing key that isn't stripped 🤔 . i am not sure how it got there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamrajjoshi @trillville