Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aci): simple table component #86140

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(aci): simple table component #86140

wants to merge 1 commit into from

Conversation

natemoo-re
Copy link
Member

Adds a simplified table component for use in ACI detail pages. Intentionally leverages the existing GridEditable primitives to avoid introducing any new grid styles.

See stories for example usage.

@natemoo-re natemoo-re requested a review from a team as a code owner February 28, 2025 21:13
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #86140       +/-   ##
===========================================
+ Coverage   42.20%   87.88%   +45.68%     
===========================================
  Files        9718     9686       -32     
  Lines      550836   548097     -2739     
  Branches    21537    21310      -227     
===========================================
+ Hits       232456   481704   +249248     
+ Misses     318031    66077   -251954     
+ Partials      349      316       -33     

@ameliahsu
Copy link
Member

ameliahsu commented Mar 3, 2025

Just a few thoughts

  • I don't believe we can define custom column widths right now? I tried providing widths to the columns object, but I could have done it wrong. This is the grid-template-columns styling on the Grid primitive we are using from GridEditable though

    export const Grid = styled('table')<{height?: string | number; scrollable?: boolean}>`
    position: inherit;
    display: grid;
    /* Overwritten by GridEditable.setGridTemplateColumns */
    grid-template-columns: repeat(auto-fill, minmax(50px, auto));

    Maybe custom widths would be implemented whenever we implement specifying collapsing behavior?

  • Would it be too complex (no longer "simple") to add pagination? We'll need that for the automation history list.

  • Could we add an empty state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants