badge: chonkify badge and tags #86207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Comment on lines
15
to
28
| return { | ||
| ...props, | ||
| type: | ||
| props.type === 'highlight' | ||
| ? 'info' | ||
| : props.type === 'error' | ||
| ? 'danger' | ||
| : props.type === 'white' | ||
| ? 'default' | ||
| : props.type === 'black' | ||
| ? 'default' | ||
| : props.type === undefined | ||
| ? 'default' | ||
| : props.type, |
There was a problem hiding this comment.
can we use a mapping instead 🫠
There was a problem hiding this comment.
I think this is the main reason why no-nested-ternary exists. Any reason it’s not turned on in sentry?
Comment on lines
15
to
28
| return { | ||
| ...props, | ||
| type: | ||
| props.type === 'highlight' | ||
| ? 'info' | ||
| : props.type === 'error' | ||
| ? 'danger' | ||
| : props.type === 'white' | ||
| ? 'default' | ||
| : props.type === 'black' | ||
| ? 'default' | ||
| : props.type === undefined | ||
| ? 'default' | ||
| : props.type, |
There was a problem hiding this comment.
Suggested change
| return { | |
| ...props, | |
| type: | |
| props.type === 'highlight' | |
| ? 'info' | |
| : props.type === 'error' | |
| ? 'danger' | |
| : props.type === 'white' | |
| ? 'default' | |
| : props.type === 'black' | |
| ? 'default' | |
| : props.type === undefined | |
| ? 'default' | |
| : props.type, | |
| const legacyTypeMapping = { | |
| highlight: 'info', | |
| error: 'danger', | |
| white: 'default', | |
| black: 'default', | |
| [undefined]: 'default' | |
| }; | |
| return { | |
| ...props, | |
| type: legacyTypeMapping[props.type] ?? props.type, |
There was a problem hiding this comment.
What is this [undefined]: 'default' 😂 ?
There was a problem hiding this comment.
It's not very happy. I honestly have little preference here because I plan to delete this afterwards
There was a problem hiding this comment.
if we make type optional in ChonkTagProps and then destruct it to ’default’ where necessary, we can do this:
const legacyTypeMapping: Partial<Record<NonNullable<TagProps['type']>, TagType>> = {
highlight: 'info',
error: 'danger',
white: 'default',
black: 'default',
};
export function chonkTagPropMapping(props: TagProps): ChonkTagProps {
return {
...props,
type: props.type && legacyTypeMapping[props.type],
};
}
Bundle ReportChanges will increase total bundle size by 2.01kB (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
|
TkDodo
approved these changes
Mar 5, 2025
philipphofmann
pushed a commit
that referenced
this pull request
Mar 6, 2025
Designs have changed, this PR adjusts them to the latest spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Designs have changed, this PR adjusts them to the latest spec