🔧 chore: fix sentry app notification action for bug found in dry run #86261
+90
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i found a bug in the dry run script where i don't migrate sentry apps which have the
label
key. This fixes that by passing it asNone
during migration.In the long run, I think we should be updating the typing on the frontend so we don't it as optional, rather
str | None
, but until we get to that reality, I basically parse out theNone
inside the NOA so when we invoke the sentry app action, we omit the label if it doesn't exist.