Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 chore: fix sentry app notification action for bug found in dry run #86261

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

iamrajjoshi
Copy link
Member

i found a bug in the dry run script where i don't migrate sentry apps which have the label key. This fixes that by passing it as None during migration.

In the long run, I think we should be updating the typing on the frontend so we don't it as optional, rather str | None, but until we get to that reality, I basically parse out the None inside the NOA so when we invoke the sentry app action, we omit the label if it doesn't exist.

@iamrajjoshi iamrajjoshi self-assigned this Mar 4, 2025
@iamrajjoshi iamrajjoshi requested a review from a team as a code owner March 4, 2025 01:10
@iamrajjoshi iamrajjoshi changed the title 🔧 chore: fix sentry app notification action 🔧 chore: fix sentry app notification action for bug found in dry run Mar 4, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...gine/migration_helpers/test_migrate_rule_action.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #86261       +/-   ##
===========================================
+ Coverage   46.68%   87.89%   +41.20%     
===========================================
  Files        9697     9714       +17     
  Lines      550003   550978      +975     
  Branches    21446    21446               
===========================================
+ Hits       256766   484264   +227498     
+ Misses     292857    66334   -226523     
  Partials      380      380               

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant