Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radio: move to components/core and add story #86265

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Mar 4, 2025

Move radio to components/core and add a story. Also removes default export and changes size prop to be aligned with our FormSize type which accepts sm | md | lg as opposed to the long form small.

CleanShot 2025-03-03 at 21 43 01@2x

@JonasBa JonasBa requested review from a team as code owners March 4, 2025 02:42
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Bundle Report

Changes will increase total bundle size by 144.14kB (0.35%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 41.7MB 144.14kB (0.35%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: app-webpack-bundle-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
chunks/app_components_avatar_actorAvatar_tsx-app_components_avatar_avatarList_tsx-app_components_cha-e41958.*.js 5 bytes 1.38MB 0.0%
chunks/app_components_assigneeBadge_tsx-app_components_charts_components_markLine_tsx-app_components-4285bc.*.js 11 bytes 1.15MB 0.0%
chunks/app_actionCreators_redirectToProject_tsx-app_actionCreators_sudoModal_tsx-app_components_aler-ee9c33.*.js -182 bytes 452.21kB -0.04%
chunks/gsApp_registerHooks_tsx.*.js 11 bytes 355.83kB 0.0%
chunks/app_utils_duration_intervalToMilliseconds_tsx-app_views_dashboards_dashboard_tsx-app_views_da-03e4f7.*.js 11 bytes 294.27kB 0.0%
chunks/app_components_core_radio_index_stories_tsx.*.js (New) 143.44kB 143.44kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-e4ffca.*.js 11 bytes 135.23kB 0.01%
chunks/app_views_performance_landing_widgets_components_widgetChartRow_tsx-app_views_performance_table_tsx.*.js 11 bytes 113.75kB 0.01%
entrypoints/app.js 68 bytes 108.68kB 0.06%
chunks/gsApp_views_decideCheckout_tsx.*.js 11 bytes 99.14kB 0.01%
chunks/gsApp_views_subscriptionPage_overview_tsx.*.js -5 bytes 58.05kB -0.01%
chunks/app_views_stories_index_tsx.*.js 168 bytes 43.57kB 0.39%
chunks/app_views_alerts_wizard_index_tsx-node_modules_react-virtualized_dist_es_CellMeasurer_CellMea-4ae9b7.*.js 3 bytes 38.32kB 0.01%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.40528579c13dffab2b38.js (New) 37.51kB 37.51kB 100.0% 🚀
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-bf54dd.*.js 104 bytes 34.95kB 0.3%
chunks/app_components_feedback_widget_feedbackWidgetButton_tsx-app_views_insights_common_components_-2f190a.*.js (New) 34.84kB 34.84kB 100.0% 🚀
chunks/app_components_charts_series_scatterSeries_tsx-app_components_feedback_widget_us*kWidg-2f9105.7f7cae38a9278fcd06e3.js (New) 34.19kB 34.19kB 100.0% 🚀
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--fbb1b9.be5506a2c88e3e207d60.js (New) 31.1kB 31.1kB 100.0% 🚀
chunks/app_components_replays_breadcrumbs_replayComparisonModal_tsx-app_utils_useResizableDrawer_tsx.*.js 11 bytes 31.01kB 0.04%
chunks/app_utils_discover_discoverQuery_tsx-app_views_performance_transactionSummary_transactionTags-d69236.*.js 12 bytes 30.57kB 0.04%
chunks/app_views_insights_common_utils_useModuleTitle_tsx-app_views_performance_trends_changedTransa-29ab4b.*.js 11 bytes 28.45kB 0.04%
chunks/app_components_forms_fields_index_stories_tsx.*.js 11 bytes 26.71kB 0.04%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.8e673bc9077840da6204.js (New) 24.18kB 24.18kB 100.0% 🚀
chunks/app_views_settings_organizationMembers_organizationMemberDetail_tsx.*.js 11 bytes 21.54kB 0.05%
chunks/app_views_insights_common_components_insightsLineChartWidget_tsx-app_views_insights_common_co-2fd359.*.js (New) 20.74kB 20.74kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.f6af4aa17abfc9753ac0.js (New) 17.41kB 17.41kB 100.0% 🚀
chunks/app_views_performance_transactionSummary_transactionEvents_eventsTable_tsx.*.js 3 bytes 16.61kB 0.02%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.d0af9fd497f420770ffa.js (New) 16.21kB 16.21kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.570a961183b15068f02d.js (New) 13.36kB 13.36kB 100.0% 🚀
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.fc030a8f7f1de06253f0.js (New) 12.34kB 12.34kB 100.0% 🚀
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-1e8a2c.*.js 104 bytes 10.84kB 0.97%
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-97ba570.*.js 104 bytes 9.7kB 1.08%
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-97ba571.*.js 104 bytes 9.7kB 1.08%
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-97ba572.*.js (New) 9.7kB 9.7kB 100.0% 🚀
chunks/app_components_onboarding_frameworkSuggestionModal_tsx.*.js 3 bytes 9.46kB 0.03%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.4da6a3a68d09896d8ed3.js (Deleted) -37.51kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_feedbackWidgetButton_tsx-app_views_insights_common_components_-07f64e.*.js (Deleted) -34.29kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_series_scatterSeries_tsx-app_components_feedback_widget_us*kWidg-2f9105.c20f7731f15196dda8b8.js (Deleted) -34.19kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--fbb1b9.37861e79b4774923776d.js (Deleted) -31.1kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.19a6fb8fcb4a191bebf1.js (Deleted) -24.18kB 0 bytes -100.0% 🗑️
chunks/app_views_insights_common_components_insightsLineChartWidget_tsx-app_views_insights_common_co-e286d9.*.js (Deleted) -20.24kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.38ead35e653d1cfa8b2a.js (Deleted) -17.41kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.fa3ba1ed98703b16498b.js (Deleted) -16.21kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.0f97120f7757cd550a32.js (Deleted) -13.36kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.2ce81e7f70b9355f80e6.js (Deleted) -12.34kB 0 bytes -100.0% 🗑️
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-4f3bc4.*.js (Deleted) -10.66kB 0 bytes -100.0% 🗑️

Files in chunks/app_actionCreators_redirectToProject_tsx-app_actionCreators_sudoModal_tsx-app_components_aler-ee9c33.*.js:

  • ./app/components/forms/controls/radioGroup.tsx → Total Size: 28.1kB

  • ./app/components/core/radio/index.tsx → Total Size: 3.61kB

Files in chunks/app_views_insights_common_utils_useModuleTitle_tsx-app_views_performance_trends_changedTransa-29ab4b.*.js:

  • ./app/views/performance/trends/changedTransactions.tsx → Total Size: 440.65kB

Files in chunks/app_components_onboarding_frameworkSuggestionModal_tsx.*.js:

  • ./app/components/onboarding/frameworkSuggestionModal.tsx → Total Size: 253.83kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants