Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): chonkify InputGroup #86282

Merged
merged 17 commits into from
Mar 5, 2025
Merged

feat(ui): chonkify InputGroup #86282

merged 17 commits into from
Mar 5, 2025

Conversation

TkDodo
Copy link
Contributor

@TkDodo TkDodo commented Mar 4, 2025

No description provided.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 4, 2025
@TkDodo TkDodo marked this pull request as ready for review March 4, 2025 14:32
@TkDodo TkDodo requested a review from a team as a code owner March 4, 2025 14:32
Copy link

codecov bot commented Mar 5, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
9633 1 9632 4
View the top 1 failed test(s) by shortest run time
Dashboards > Detail prebuilt dashboards assigns unique IDs to all widgets so grid keys are unique
Stack Traces | 1.34s run time
Error: Unable to find an element with the text: Default Widget 1. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../views/dashboards/detail.spec.tsx:191:48)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@TkDodo TkDodo merged commit 0112821 into master Mar 5, 2025
41 checks passed
@TkDodo TkDodo deleted the tkdodo/feat/chonkify-inputGroup branch March 5, 2025 10:34
jan-auer added a commit that referenced this pull request Mar 5, 2025
* master: (809 commits)
  feat(partnership): set password email template (#86366)
  feat(ui): chonkify InputGroup (#86282)
  feat(laravel-insights): New caches widget (#86367)
  fix(api): fix error in OrganizationSamplingProjectSpanCountsEndpoint when metric not set for projects (#86271)
  chore(shellmayr): remove metrics endpoints from api publish list (#86272)
  feat(laravel-insights): New queries widget (#86279)
  fix(seer-issues-patch) More logs (#86173)
  fix(seer-issues-patch) Loosen issues first_seen_at to 52 weeks (#86364)
  chore(stacktrace): Convert `RawContent` to functional component  (#85985)
  ref(aci): misc fixes for issue alert migration (#86342)
  fix(issue-details): Fix edge case with sidebar (#86041)
  chore(sentry apps): write out the categories for publishing emails (#86357)
  feat(releases): add user count/rate session breakdown charts on insights (#86353)
  chore(sentry app): update tests and remove FF for frontend publish flow (#86317)
  ref(releases): add ProjectBadge to release tables on insights (#86319)
  ref: fix types for endpoints.internal.mail (#86348)
  feat(releases): add session health breakdown chart to insights (#86340)
  ref(flags): improve group flags coverage on topValues and totalValues (#86345)
  chore(ACI): Make functions reusable, update tests (#86253)
  fix(aci): workflow name should allow 256 chars (#86344)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants