ref(eap): cleanup from custom formulas #86330
Merged
+107
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
wmak
approved these changes
Mar 4, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #86330 +/- ##
===========================================
+ Coverage 46.64% 87.90% +41.26%
===========================================
Files 9732 9726 -6
Lines 551671 551788 +117
Branches 21533 21445 -88
===========================================
+ Hits 257304 485031 +227727
+ Misses 293978 66371 -227607
+ Partials 389 386 -3 |
philipphofmann
pushed a commit
that referenced
this pull request
Mar 6, 2025
Part 1 of a few cleanups from #85662 The term `aggregate` and `function` were used quite interchangeably. This was fine before, but now that we support custom functions, this terminology get's a bit confusing. This PR does a bunch of cleanup to resolved this. 1. A `Function` should be used as a `non-attribute` column, this means an `Aggregate`, `ConditionalAggregate` or `Formula` is a type of function. Functions may or may not take parameters. This also better matches what the protobuf defines as a `Column`, https://github.com/getsentry/sentry-protos/blob/671d2784e499b9306baf3dd86cff382bda724b3d/proto/sentry_protos/snuba/v1/endpoint_trace_item_table.proto#L81-L83 2. `FunctionDefinition` and `ResolvedFunction` were renamed to `Aggregate Definition` and `ResolvedAggregate` 3. A base `FunctionDefinition` and `FunctionDefinition` were created 4. Methods `resolve_aggregate` and `resolve_aggregates` were renamed to `resolved_function` and `resolve_functions`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of a few cleanups from #85662
The term
aggregateandfunctionwere used quite interchangeably. This was fine before, but now that we support custom functions, this terminology get's a bit confusing. This PR does a bunch of cleanup to resolved this.Functionshould be used as anon-attributecolumn, this means anAggregate,ConditionalAggregateorFormulais a type of function. Functions may or may not take parameters. This also better matches what the protobuf defines as aColumn, https://github.com/getsentry/sentry-protos/blob/671d2784e499b9306baf3dd86cff382bda724b3d/proto/sentry_protos/snuba/v1/endpoint_trace_item_table.proto#L81-L83FunctionDefinitionandResolvedFunctionwere renamed toAggregate DefinitionandResolvedAggregateFunctionDefinitionandFunctionDefinitionwere createdresolve_aggregateandresolve_aggregateswere renamed toresolved_functionandresolve_functions