Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(ui): move textarea to components/core #86381

Merged
merged 2 commits into from
Mar 5, 2025
+14 −16
Merged

ref(ui): move textarea to components/core #86381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e660efa
ref: move textarea
TkDodo Mar 5, 2025
0783aec
ref: adapt imports
TkDodo Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions static/app/components/core/input/inputGroup.chonk.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {css, type DO_NOT_USE_ChonkTheme} from '@emotion/react';
import styled from '@emotion/styled';

import {Input} from 'sentry/components/core/input/index';
import Textarea from 'sentry/components/forms/controls/textarea';
import {TextArea} from 'sentry/components/core/textarea';
import {space} from 'sentry/styles/space';
import type {FormSize, StrictCSSObject} from 'sentry/utils/theme';
import {chonkStyled} from 'sentry/utils/theme/theme.chonk';
Expand Down Expand Up @@ -59,7 +59,7 @@ export const ChonkStyledInput = chonkStyled(Input)<InputStyleProps>`
${chonkInputStyles}
`;

export const ChonkStyledTextArea = chonkStyled(Textarea)<InputStyleProps>`
export const ChonkStyledTextArea = chonkStyled(TextArea)<InputStyleProps>`
${chonkInputStyles}
`;

Expand Down
4 changes: 2 additions & 2 deletions static/app/components/core/input/inputGroup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ import {
InputItemsWrap,
type InputStyleProps,
} from 'sentry/components/core/input/inputGroup.chonk';
import type {TextAreaProps} from 'sentry/components/forms/controls/textarea';
import _TextArea from 'sentry/components/forms/controls/textarea';
import type {TextAreaProps} from 'sentry/components/core/textarea';
import {TextArea as _TextArea} from 'sentry/components/core/textarea';
import type {FormSize} from 'sentry/utils/theme';
import {withChonk} from 'sentry/utils/theme/withChonk';

Expand Down
6 changes: 2 additions & 4 deletions ...pp/components/forms/controls/textarea.tsx → ...ic/app/components/core/textarea/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const TextAreaControl = forwardRef(function TextAreaControl(

TextAreaControl.displayName = 'TextAreaControl';

const TextArea = styled(Input.withComponent(TextAreaControl), {
export const TextArea = styled(Input.withComponent(TextAreaControl), {
shouldForwardProp: (p: string) =>
['autosize', 'rows', 'maxRows'].includes(p) || isPropValid(p),
})`
Expand All @@ -52,6 +52,4 @@ const TextArea = styled(Input.withComponent(TextAreaControl), {
height: unset;
min-height: unset;
`}
`;

export default TextArea as unknown as typeof TextAreaControl;
` as unknown as typeof TextAreaControl;
2 changes: 1 addition & 1 deletion static/app/components/events/autofix/autofixDiff.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {type Change, diffWords} from 'diff';

import {addErrorMessage} from 'sentry/actionCreators/indicator';
import {Button} from 'sentry/components/button';
import {TextArea} from 'sentry/components/core/textarea';
import AutofixHighlightPopup from 'sentry/components/events/autofix/autofixHighlightPopup';
import {
type DiffLine,
Expand All @@ -12,7 +13,6 @@ import {
} from 'sentry/components/events/autofix/types';
import {makeAutofixQueryKey} from 'sentry/components/events/autofix/useAutofix';
import {useTextSelection} from 'sentry/components/events/autofix/useTextSelection';
import TextArea from 'sentry/components/forms/controls/textarea';
import InteractionStateLayer from 'sentry/components/interactionStateLayer';
import {DIFF_COLORS} from 'sentry/components/splitDiff';
import {IconChevron, IconClose, IconDelete, IconEdit} from 'sentry/icons';
Expand Down
4 changes: 2 additions & 2 deletions static/app/components/featureFeedback/feedbackModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import type {ModalRenderProps} from 'sentry/actionCreators/modal';
import {Button} from 'sentry/components/button';
import ButtonBar from 'sentry/components/buttonBar';
import {Alert} from 'sentry/components/core/alert';
import Textarea from 'sentry/components/forms/controls/textarea';
import {TextArea} from 'sentry/components/core/textarea';
import FieldGroup from 'sentry/components/forms/fieldGroup';
import SelectField from 'sentry/components/forms/fields/selectField';
import type {Data} from 'sentry/components/forms/types';
Expand Down Expand Up @@ -307,7 +307,7 @@ export function FeedbackModal<T extends Data>({
flexibleControlStateSize
stacked
>
<Textarea
<TextArea
name="additional-feedback"
value={state.additionalInfo}
rows={5}
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/dashboards/widgetBuilder/components/nameAndDescFields.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {Fragment, useState} from 'react';
import styled from '@emotion/styled';

import {Button} from 'sentry/components/button';
import TextArea from 'sentry/components/forms/controls/textarea';
import {TextArea} from 'sentry/components/core/textarea';
import TextField from 'sentry/components/forms/fields/textField';
import {t} from 'sentry/locale';
import {space} from 'sentry/styles/space';
Expand Down
4 changes: 2 additions & 2 deletions static/app/views/settings/organizationRelay/modals/form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import styled from '@emotion/styled';

import {addErrorMessage, addSuccessMessage} from 'sentry/actionCreators/indicator';
import {Input} from 'sentry/components/core/input';
import Textarea from 'sentry/components/forms/controls/textarea';
import {TextArea} from 'sentry/components/core/textarea';
import FieldGroup from 'sentry/components/forms/fieldGroup';
import {FieldHelp} from 'sentry/components/forms/fieldGroup/fieldHelp';
import TextCopyInput from 'sentry/components/textCopyInput';
Expand Down Expand Up @@ -123,7 +123,7 @@ function Form({
inline={false}
stacked
>
<Textarea
<TextArea
name="description"
placeholder={t('Description')}
onChange={handleChange('description')}
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/settings/project/projectOwnership/ownerInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {addErrorMessage, addSuccessMessage} from 'sentry/actionCreators/indicato
import {Client} from 'sentry/api';
import {Button} from 'sentry/components/button';
import ButtonBar from 'sentry/components/buttonBar';
import TextArea from 'sentry/components/forms/controls/textarea';
import {TextArea} from 'sentry/components/core/textarea';
import Panel from 'sentry/components/panels/panel';
import PanelBody from 'sentry/components/panels/panelBody';
import PanelHeader from 'sentry/components/panels/panelHeader';
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/settings/project/projectOwnership/rulesPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import styled from '@emotion/styled';

import TextArea from 'sentry/components/forms/controls/textarea';
import {TextArea} from 'sentry/components/core/textarea';
import Panel from 'sentry/components/panels/panel';
import PanelBody from 'sentry/components/panels/panelBody';
import PanelHeader from 'sentry/components/panels/panelHeader';
Expand Down
Loading