Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch: chonkify the switch component #86389

Merged
merged 26 commits into from
Mar 5, 2025
Merged

switch: chonkify the switch component #86389

merged 26 commits into from
Mar 5, 2025
+196 −63

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Mar 5, 2025

Light mode
CleanShot 2025-03-05 at 10 43 19@2x

Dark mode
CleanShot 2025-03-05 at 10 43 16@2x

JonasBa and others added 23 commits March 4, 2025 10:24
@JonasBa
switch: move to components/core
6b26a4e
@JonasBa
Merge branch 'master' into jb/components/boolean-core
0ddb184
@JonasBa
switch: remove forwardedRef
13317d4
@JonasBa
switch: remove forceIsActiveColor
f3c11e8
@JonasBa
switch: use native name prop
68cd666
@JonasBa
switch: use input html attributes for type
fea4a7e
@JonasBa
switch: use checked and disabled
093d356
@JonasBa
switch: change component to use input like props
84436f5
@JonasBa
switch: remove explicit id prop
80b8ba3
@JonasBa
Merge branch 'master' into jb/components/boolean-refactor
9feb9e5
@JonasBa
switch: add test
13d8855
@JonasBa
switch: fix boolean field test
9739037
@JonasBa
switch: add toggle config
c3bcea4
@JonasBa
switch: sue config for value
36dcac3
@JonasBa
switch: remove styleProps
df32976
@JonasBa
switch: semantically, this is a checkbox
6694bc2
@JonasBa
switch: use onchange handler
fb41f27
@JonasBa
switch: use onChange
6f5dcd4
@JonasBa
fixup! switch: use onChange
c1cfef8
@JonasBa
switch: add chonk components
c269d24
@JonasBa
switch: adjust styling
9a1efc0
@JonasBa
switch: chonkify component
ff74345
@JonasBa
Merge branch 'master' into jb/components/boolean-chonkify
ae77b0a
@JonasBa JonasBa requested a review from a team as a code owner March 5, 2025 15:46
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 5, 2025
@JonasBa JonasBa force-pushed the jb/components/boolean-chonkify branch from 2a00194 to 98c9980 Compare March 5, 2025 15:48
@JonasBa @github-advanced-security
Potential fix for code scanning alert no. 611: Incomplete string esca…
c63f2f4 
…ping or encoding

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@natemoo-re natemoo-re self-requested a review March 5, 2025 16:32
@codecov Codecov
Copy link

codecov bot commented Mar 5, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 17.03kB (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 42.47MB 17.03kB (0.04%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: app-webpack-bundle-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
chunks/app_components_avatar_actorAvatar_tsx-app_components_avatar_avatarList_tsx-app_components_cha-7ec24d.*.js (New) 1.38MB 1.38MB 100.0% 🚀
chunks/app_components_assigneeBadge_tsx-app_components_charts_components_markLine_tsx-app_components-38886d.*.js (New) 1.16MB 1.16MB 100.0% 🚀
chunks/app_actionCreators_redirectToProject_tsx-app_actionCreators_sudoModal_tsx-app_components_aler-d18754.*.js 3.83kB 457.02kB 0.84%
chunks/app_views_issueDetails_groupEventDetails_groupEventDetails_tsx.*.js -261 bytes 361.32kB -0.07%
chunks/app_actionCreators_preferences_tsx-app_components_avatar_actorAvatar_tsx-app_components_confi-71c9ce.*.js 191 bytes 301.39kB 0.06%
chunks/app_utils_duration_intervalToMilliseconds_tsx-app_views_dashboards_dashboard_tsx-app_views_da-03e4f7.*.js 31 bytes 293.85kB 0.01%
chunks/app_actionCreators_members_tsx-app_components_avatar_avatarList_tsx-app_components_deprecated-76913d.*.js (New) 162.41kB 162.41kB 100.0% 🚀
chunks/app_components_core_switch_index_stories_tsx.*.js -298 bytes 148.23kB -0.2%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_projectDetail_index_tsx.39e831cd05db789bbe94.js (New) 125.93kB 125.93kB 100.0% 🚀
entrypoints/app.js 42 bytes 108.5kB 0.04%
entrypoints/pipeline.js 41 bytes 37.41kB 0.11%
chunks/app_components_compactSelect_list_tsx-app_views_settings_components_text_textBlock_tsx.*.js -3.46kB 37.3kB -8.48%
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-bf54dd.*.js 104 bytes 34.95kB 0.3%
chunks/app_components_feedback_widget_feedbackWidgetButton_tsx-app_views_insights_common_components_-2f190a.*.js (New) 34.58kB 34.58kB 100.0% 🚀
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--fbb1b9.1fa73d3d0fda401a9947.js (New) 31.1kB 31.1kB 100.0% 🚀
chunks/app_components_emptyStateWarning_tsx-app_components_modals_bulkEditMonitorsModal_tsx-app_util-63f737.*.js (New) 28.58kB 28.58kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.ec47b017d36ae0c4ee5e.js (New) 25.7kB 25.7kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.aa6389cec181c2b88431.js (New) 24.18kB 24.18kB 100.0% 🚀
chunks/app_components_tours_tour_stories_tsx.*.js -5.49kB 21.97kB -20.0%
chunks/app_views_insights_common_components_insightsLineChartWidget_tsx-app_views_insights_common_co-2fd359.*.js (New) 20.58kB 20.58kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.c9034997839d5690963e.js (New) 17.41kB 17.41kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.5fdab48a3abba37f459e.js (New) 16.21kB 16.21kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.975faa7bce71b7596980.js (New) 13.36kB 13.36kB 100.0% 🚀
chunks/app_views_dashboards_widgets_bigNumberWidget_bigNumberWidgetVisualization_stories_tsx-app_vie-ded72c.*.js -69 bytes 12.86kB -0.53%
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-01ad31.*.js -69 bytes 12.45kB -0.55%
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.40ed4760ec535bc13a38.js (New) 12.34kB 12.34kB 100.0% 🚀
chunks/app_components_tabs_tabList_tsx-app_components_tabs_tabPanels_tsx-app_utils_useOverlay_tsx.*.js (New) 11.3kB 11.3kB 100.0% 🚀
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-1e8a2c.*.js 104 bytes 10.84kB 0.97%
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-97ba570.*.js 104 bytes 9.7kB 1.08%
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-97ba571.*.js 104 bytes 9.7kB 1.08%
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-97ba572.*.js (New) 9.7kB 9.7kB 100.0% 🚀
chunks/app_views_dashboards_widgets_widget_widget_tsx.*.js -69 bytes 7.13kB -0.96%
chunks/app_components_avatar_actorAvatar_tsx-app_components_avatar_avatarList_tsx-app_components_cha-e41958.*.js (Deleted) -1.37MB 0 bytes -100.0% 🗑️
chunks/app_components_assigneeBadge_tsx-app_components_charts_components_markLine_tsx-app_components-4285bc.*.js (Deleted) -1.16MB 0 bytes -100.0% 🗑️
chunks/app_actionCreators_members_tsx-app_components_avatar_avatarList_tsx-app_components_deprecated-c50dcc.*.js (Deleted) -156.64kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_projectDetail_index_tsx.7e3ca389b37b9ac0e9f0.js (Deleted) -125.93kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_feedbackWidgetButton_tsx-app_views_insights_common_components_-07f64e.*.js (Deleted) -34.02kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--fbb1b9.6c2a603920d602561d7d.js (Deleted) -31.1kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.22501f46ff89f0bfe25c.js (Deleted) -25.7kB 0 bytes -100.0% 🗑️
chunks/app_components_emptyStateWarning_tsx-app_components_modals_bulkEditMonitorsModal_tsx.*.js (Deleted) -25.1kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.9e2099a85c5cbd3916e0.js (Deleted) -24.18kB 0 bytes -100.0% 🗑️
chunks/app_views_insights_common_components_insightsLineChartWidget_tsx-app_views_insights_common_co-e286d9.*.js (Deleted) -20.07kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.08a1b76e9e0c650db476.js (Deleted) -17.41kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.151c4532846be2a6019e.js (Deleted) -16.21kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.db0ae98d98ceab71cdfe.js (Deleted) -13.36kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.fdddae2373fdd6c7263b.js (Deleted) -12.34kB 0 bytes -100.0% 🗑️
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-4f3bc4.*.js (Deleted) -10.66kB 0 bytes -100.0% 🗑️
chunks/app_components_tabs_tabList_tsx-app_components_tabs_tabPanels_tsx.*.js (Deleted) -7.8kB 0 bytes -100.0% 🗑️

@JonasBa JonasBa enabled auto-merge (squash) March 5, 2025 17:21
@JonasBa JonasBa merged commit 5939547 into master Mar 5, 2025
42 checks passed
@JonasBa JonasBa deleted the jb/components/boolean-chonkify branch March 5, 2025 17:21
philipphofmann pushed a commit that referenced this pull request Mar 6, 2025
@JonasBa @github-advanced-security @philipphofmann
switch: chonkify the switch component (#86389)
654d69f 
Light mode
![CleanShot 2025-03-05 at 10 43
19@2x](https://github.com/user-attachments/assets/2e5c19c1-0444-4b56-8be7-cc54f12fb658)

Dark mode
![CleanShot 2025-03-05 at 10 43
16@2x](https://github.com/user-attachments/assets/249a48d3-edc8-4529-a6aa-f194096055e3)

---------

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

@natemoo-re natemoo-re Awaiting requested review from natemoo-re

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonasBa @TkDodo