feat(explore): add sentry.normalized_description to trace explorer #86394
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
mjq
reviewed
Mar 5, 2025
static/app/utils/fields/index.ts
Outdated
| @@ -1186,7 +1187,14 @@ export const TRACE_FIELD_DEFINITIONS: Record<TraceFields, FieldDefinition> = { | |||
| valueType: FieldValueType.STRING, | |||
| }, | |||
| [SpanIndexedField.SPAN_DESCRIPTION]: { | |||
| desc: t('Parameterized and scrubbed description of the span'), | |||
| desc: t('Scrubbed description of the span'), | |||
There was a problem hiding this comment.
Is this even scrubbed? I'm pretty sure it's just the raw description as received in the transaction event.
There was a problem hiding this comment.
Now that I think about it, I also am pretty sure it's the raw description as received in the transaction event. But is it possible it's scrubbed on the server side via https://docs.sentry.io/security-legal-pii/scrubbing/server-side-scrubbing/ ?
There was a problem hiding this comment.
I think if I changed this to raw_description of the span it would still be technically accurate. All fields imply PII scrubbing, so no need to mention it.
mjq
reviewed
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to search for
sentry.normalized_descriptionCorrects description of the
span.descriptionfield, it isn't technically always parameterized (for example thehttp.clientspans contain the full url`