Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hybrid-cloud): Ensure release registry cache is available in control #86400

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

andreiborza
Copy link
Member

@andreiborza andreiborza commented Mar 5, 2025

When setting up the AWS integration in Sentry and trying to automatically add the lambda layer to lambda functions the underlying code encounters an empty release-registry cache: https://sentry.sentry.io/issues/5289437499/events/f3e461d3164a442587c3f9da8ef86255/

This happens from this view:
image

But it is possible to do from this view:
image

From the linked issue above, it looks like that code runs in the control silo, but the task to populate the cache with release-registry data is only running for region silos.

This PR adds the celery task to the control queue.

Related: #85322, #86365

Might stem from: #53038

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 5, 2025
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Control silo cache is separate from the region caches.

@andreiborza andreiborza merged commit e868ee8 into master Mar 5, 2025
51 checks passed
@andreiborza andreiborza deleted the ab/fetch-release-registry-in-control branch March 5, 2025 23:38
philipphofmann pushed a commit that referenced this pull request Mar 6, 2025
…trol (#86400)

When [setting up the AWS integration in
Sentry](https://docs.sentry.io/organization/integrations/cloud-monitoring/aws-lambda/)
and trying to automatically add the lambda layer to lambda functions the
underlying code encounters an empty release-registry cache:
https://sentry.sentry.io/issues/5289437499/events/f3e461d3164a442587c3f9da8ef86255/

This happens from this view: 

![image](https://github.com/user-attachments/assets/55ef7664-ba11-4677-8c98-e2d9cc139233)

But it is possible to do from this view:

![image](https://github.com/user-attachments/assets/5dd745d4-2f5c-4c4a-938c-9522c0a66b9d)

From the linked issue above, it looks like that code runs in the control
silo, but the task to populate the cache with release-registry data is
only running for region silos.

This PR adds the celery task to the control queue.

Related: #85322,
#86365

Might stem from: #53038
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants