migration(shared-views): Add visibility column to groupsearchview table

[MichaelSun48]

Adds a visibility enum column to the groupsearchview table. As the name implies, this will be used to inform what visibility scope a view has in the future.

This is also designed to be extensible to allow for new visibility scopes in the future. We're planning to have "team" and "system" (sentry presets) in the future.

[codecov]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
327	1	326	41

View the full list of 1 ❄️ flaky tests

tests.acceptance.test_organization_global_selection_header.OrganizationGlobalHeaderTest test_issues_list_to_details_and_back_with_initial_project

Flake rate in main: 22.22% (Passed 7 times, Failed 2 times)

Stack Traces | 57.1s run time

#x1B[1m#x1B[31mtests/acceptance/test_organization_global_selection_header.py#x1B[0m:340: in test_issues_list_to_details_and_back_with_initial_project
    assert f"project={self.project_3.id}" in self.browser.current_url
#x1B[1m#x1B[31mE   AssertionError: assert 'project=4555675845394436' in 'http://172.17.0.1:.../organizations/rowdy-tiger/issues/?project=4555675845394435&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&stream_index=0'#x1B[0m
#x1B[1m#x1B[31mE    +  where 'http://172.17.0.1:.../organizations/rowdy-tiger/issues/?project=4555675845394435&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&stream_index=0' = <sentry.testutils.pytest.selenium.Browser object at 0x7f04b6680de0>.current_url#x1B[0m
#x1B[1m#x1B[31mE    +    where <sentry.testutils.pytest.selenium.Browser object at 0x7f04b6680de0> = <sentry.testutils.silo.OrganizationGlobalHeaderTest testMethod=test_issues_list_to_details_and_back_with_initial_project>.browser#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[JoshFerge]

i think using a CharField is fine here, but at what scale would it make sense to use an integer mapping for this instead? e.g

sentry/src/sentry/models/group.py

Line 158 in 01dd303

class GroupStatus:

?

[MichaelSun48]

That's a good question that I'm not really sure how to answer. To me, it seems like the only benefit of switching to an integer mapping is marginally better performance in a couple niche areas. It's hard to draw a line for when those performance improvements actually warrant a refactor. What do you think?

[JoshFerge]

yes, if we did high volume queries and needed to eek out a bit more performance, it would help with that. in addition, it saves a small amount of data, which could be important if this table needed to scale to billions of rows. likely not, but something to consider for bigger tables (e.g. anything to do with GroupedMessage).

given that this view in general will be constrained by user action and never grow that large, it is probably safe to assume that our current char based column will be fine.

[github-actions]

This PR has a migration; here is the generated SQL for src/sentry/migrations/0839_add_visibility_column_to_groupsearchview.py ()

--
-- Add field visibility to groupsearchview
--
ALTER TABLE "sentry_groupsearchview" ADD COLUMN "visibility" varchar(16) DEFAULT 'owner' NOT NULL;