Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump winit #101

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Bump winit #101

merged 1 commit into from
Oct 18, 2019

Conversation

SSheldon
Copy link
Contributor

The version of winit used in the window example pins an old version of cocoa lacking a soundness fix (servo/core-foundation-rs#340) for undefined behavior in an upcoming version of rust (rust-lang/rust#65355).

Testing done: ran the window example after this change; it compiles and looks fine!

The version of winit used in the window example pins an old version of
cocoa lacking a soundness fix (servo/core-foundation-rs#340) for
undefined behavior in an upcoming version of rust (rust-lang/rust#65355).
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Oct 18, 2019
101: Bump winit r=kvark a=SSheldon

The version of winit used in the window example pins an old version of cocoa lacking a soundness fix (servo/core-foundation-rs#340) for undefined behavior in an upcoming version of rust (rust-lang/rust#65355).

Testing done: ran the window example after this change; it compiles and looks fine!

Co-authored-by: Steven Sheldon <steven@sasheldon.com>
@bors
Copy link
Contributor

bors bot commented Oct 18, 2019

Build succeeded

@bors bors bot merged commit 7d7a9fc into gfx-rs:master Oct 18, 2019
@SSheldon SSheldon deleted the bump_winit branch October 18, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants