Add ability to sort sidecar #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now one can sort the sidecar if the alphabeticallySortedSidecar field is set to true on a page. This is very helpful for things like a reference, where one is looking up the correct values for a setting.
This will probably help with ghostty-org#155
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The right solution here would be to alphabetically sort the content, if we found that was the right sorting for this content. The sidecar itself is supposed to be in the same order as the content. When you scroll now on these pages, the sidecar jumps erratically. out.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially started a discussion here ghostty-org/ghostty#3397 , however seeing this feature might help with other issues like #155 , I figured I'ld open a PR directly.
This PR adds the ability to alphabetically sort the sidecar on any given view one wants.
This helps me a lot when I am looking for configuration options and I know almost what it's named, or what I believe it should be named.
I also see that this is wanted on the keybinding page.
I opted not to sort the content of these pages, because I do find it useful to be able to show the most common requested config first, regardless of whether this is will be first in a sorted list.
Before (sidecar unsorted):
After (sidecar sorted):