Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListView sample with code only and ListItem template #1022

Merged
merged 1 commit into from
Feb 21, 2024
Merged

ListView sample with code only and ListItem template #1022

merged 1 commit into from
Feb 21, 2024

Conversation

kashifsoofi
Copy link
Contributor

  • I agree that my contribution may be licensed either under MIT or any version of LGPL license.

@kashifsoofi kashifsoofi force-pushed the ListView-Example branch 6 times, most recently from 092e201 to c295cdd Compare February 16, 2024 21:19
badcel
badcel previously requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@badcel badcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. All in all this looks already pretty good to me. I'm no expert in ListView but as the sample works I think it is fine.

It would be nice if you could address my remarks, afterwards, we can land this sample 🚀

src/Samples/Gtk-4.0/ListView/TemplateListViewWindow.cs Outdated Show resolved Hide resolved
src/Samples/Gtk-4.0/ListView/CodeListViewWindow.cs Outdated Show resolved Hide resolved
src/Samples/Gtk-4.0/ListView/ListView.csproj Outdated Show resolved Hide resolved
@kashifsoofi
Copy link
Contributor Author

Done

@kashifsoofi kashifsoofi requested a review from badcel February 20, 2024 22:08
@badcel badcel dismissed their stale review February 21, 2024 14:14

Looks good to me 👍

@badcel badcel merged commit fbb59bf into gircore:main Feb 21, 2024
3 checks passed
@kashifsoofi kashifsoofi deleted the ListView-Example branch February 21, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badcel badcel Awaiting requested review from badcel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kashifsoofi @badcel