Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridView Sample with StringList and CustomObject ListStore #1024

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

kashifsoofi
Copy link
Contributor

  • I agree that my contribution may be licensed either under MIT or any version of LGPL license.

@kashifsoofi kashifsoofi changed the title StringListGridViewWindow GridView Sample with StringList and CustomObject ListStore Feb 21, 2024
Copy link
Member

@badcel badcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

When I run the sample the first time the SVG files where not displayed. This happened because my working directory was inside the bin/debug folder which does not contain the Resources folder.

Perhaps adding something like this to the csproj file is a good idea as the path is a relative one:

<ItemGroup>
   <None Include="$(ProjectDir)Resources\**" CopyToOutputDirectory="PreserveNewest" />
</ItemGroup>
  • Can you confirm that the used SVG files are allowed to be used?
  • Can you add some link to the original SVG source in the source code as a comment so it is easy to find the original files?

@kashifsoofi
Copy link
Contributor Author

Project file updated, I have added README.md with links to the SVG files.
From SVG Repo

Download free SVG vectors and icons for commercial use.

@kashifsoofi kashifsoofi requested a review from badcel February 21, 2024 21:48
@badcel badcel merged commit 7e79e52 into gircore:main Feb 23, 2024
3 checks passed
@kashifsoofi kashifsoofi deleted the GridView-Sample branch February 25, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants