C# 13: Partial properties and indexers. #18533
Conversation
michaelnebel
force-pushed
the
csharp/partialmembers
branch
6 times, most recently
from
ca0f73b to
ec17a0e
Compare
|
DCA looks good. |
There was a problem hiding this comment.
Copilot reviewed 10 out of 25 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- csharp/ql/test/library-tests/dataflow/fields/FieldFlow.expected: Language not supported
- csharp/ql/test/library-tests/dataflow/indexers/IndexerFlow.expected: Language not supported
- csharp/ql/test/library-tests/dataflow/indexers/IndexerFlow.ql: Language not supported
- csharp/ql/test/library-tests/dispatch/CallGraph.expected: Language not supported
- csharp/ql/test/library-tests/dispatch/GetADynamicTarget.expected: Language not supported
- csharp/ql/test/library-tests/dispatch/viableCallable.expected: Language not supported
- csharp/ql/test/library-tests/partial/MethodIsPartial.expected: Language not supported
- csharp/ql/test/library-tests/partial/Partial1.expected: Language not supported
- csharp/ql/test/library-tests/partial/Partial2.expected: Language not supported
- csharp/ql/test/library-tests/partial/PartialAccessors.expected: Language not supported
- csharp/ql/test/library-tests/partial/PartialAccessors.ql: Language not supported
- csharp/ql/test/library-tests/partial/PartialIndexers.expected: Language not supported
- csharp/extractor/Semmle.Extraction.CSharp/Entities/Indexer.cs: Evaluated as low risk
- csharp/extractor/Semmle.Extraction.CSharp/Entities/Accessor.cs: Evaluated as low risk
- csharp/ql/test/library-tests/dataflow/fields/D.cs: Evaluated as low risk
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
… accessor implementations instead of declarations.
michaelnebel
force-pushed
the
csharp/partialmembers
branch
from
1e9a7bd to
501f985
Compare
| @@ -30,6 +30,10 @@ protected Accessor(Context cx, IMethodSymbol init, IPropertySymbol property) | |||
| return props.SingleOrDefault(); | |||
| } | |||
|
|
|||
| public override bool NeedsPopulation => | |||
| base.NeedsPopulation && | |||
| !Symbol.IsPartialDefinition; // Accessors always have an implementing declaration as well. | |||
There was a problem hiding this comment.
I don't think that aligns with how we extract partial methods; for partial methods we still only extract one entity, but it will have multiple locations.
There was a problem hiding this comment.
Not sure that I understand the comparison to partial methods. In this case we don't want to extract the methodsymbol used in the declaring defintion (as this is not a callable).
There was a problem hiding this comment.
But I think we may still want to extract it's location, like we do for partial methods.
In this PR we make support for partial property and indexer definitions (as described here).
As opposed to partial methods it is worth noting that partial indexers and properties always both have a declaring declaration and an implementation declaration. Thus we need to disregard the declaration get and set (as they are not callables).