-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll, Sidehop, and Equip Swap trainers #45
Open
nfaltermeier
wants to merge
35
commits into
glankk:master
Choose a base branch
from
nfaltermeier:trainer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An early and a'perfect or late message can be made for same sidehop
imo its still to early for a trainer to be merged, I had wanted to expand on the trainer overall a bit before doing so. But yeah if this does get merged I am ok with my work being merged in :D Would prefer if the hess stuff wasnt in the codebase at all if it does get merged early. Planned on starting from scratch with it anyway. |
It only listens 5 frames late rather than 7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created an equip swap trainer, and with Fig's approval also touched up and included his sidehop and roll trainers.
Adds a new menu with check boxes to enable a global overlay for each of the trainer types. The overlay gives feedback about failures and shows a streak of successful executions.
Currently the trainer and savestates do not interact at all, I welcome feedback on this.