Skip to content

Commit

Permalink
WebAPI: Don't trim string parameters
Browse files Browse the repository at this point in the history
  • Loading branch information
glassez committed Feb 10, 2025
1 parent b052ad0 commit 308789a
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions src/webui/api/rsscontroller.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ void RSSController::addFolderAction()
{
requireParams({u"path"_s});

const QString path = params()[u"path"_s].trimmed();
const QString path = params()[u"path"_s];
const nonstd::expected<void, QString> result = RSS::Session::instance()->addFolder(path);
if (!result)
throw APIError(APIErrorType::Conflict, result.error());
Expand All @@ -59,8 +59,8 @@ void RSSController::addFeedAction()
{
requireParams({u"url"_s, u"path"_s});

const QString url = params()[u"url"_s].trimmed();
const QString path = params()[u"path"_s].trimmed();
const QString url = params()[u"url"_s];
const QString path = params()[u"path"_s];
const nonstd::expected<void, QString> result = RSS::Session::instance()->addFeed(url, (path.isEmpty() ? url : path));
if (!result)
throw APIError(APIErrorType::Conflict, result.error());
Expand All @@ -70,8 +70,8 @@ void RSSController::setFeedURLAction()
{
requireParams({u"path"_s, u"url"_s});

const QString path = params()[u"path"_s].trimmed();
const QString url = params()[u"url"_s].trimmed();
const QString path = params()[u"path"_s];
const QString url = params()[u"url"_s];
const nonstd::expected<void, QString> result = RSS::Session::instance()->setFeedURL(path, url);
if (!result)
throw APIError(APIErrorType::Conflict, result.error());
Expand All @@ -81,7 +81,7 @@ void RSSController::removeItemAction()
{
requireParams({u"path"_s});

const QString path = params()[u"path"_s].trimmed();
const QString path = params()[u"path"_s];
const nonstd::expected<void, QString> result = RSS::Session::instance()->removeItem(path);
if (!result)
throw APIError(APIErrorType::Conflict, result.error());
Expand All @@ -91,8 +91,8 @@ void RSSController::moveItemAction()
{
requireParams({u"itemPath"_s, u"destPath"_s});

const QString itemPath = params()[u"itemPath"_s].trimmed();
const QString destPath = params()[u"destPath"_s].trimmed();
const QString itemPath = params()[u"itemPath"_s];
const QString destPath = params()[u"destPath"_s];
const nonstd::expected<void, QString> result = RSS::Session::instance()->moveItem(itemPath, destPath);
if (!result)
throw APIError(APIErrorType::Conflict, result.error());
Expand Down Expand Up @@ -146,8 +146,8 @@ void RSSController::setRuleAction()
{
requireParams({u"ruleName"_s, u"ruleDef"_s});

const QString ruleName {params()[u"ruleName"_s].trimmed()};
const QByteArray ruleDef {params()[u"ruleDef"_s].trimmed().toUtf8()};
const QString ruleName {params()[u"ruleName"_s]};
const QByteArray ruleDef {params()[u"ruleDef"_s].toUtf8()};

const auto jsonObj = QJsonDocument::fromJson(ruleDef).object();
RSS::AutoDownloader::instance()->setRule(RSS::AutoDownloadRule::fromJsonObject(jsonObj, ruleName));
Expand All @@ -157,8 +157,8 @@ void RSSController::renameRuleAction()
{
requireParams({u"ruleName"_s, u"newRuleName"_s});

const QString ruleName {params()[u"ruleName"_s].trimmed()};
const QString newRuleName {params()[u"newRuleName"_s].trimmed()};
const QString ruleName {params()[u"ruleName"_s]};
const QString newRuleName {params()[u"newRuleName"_s]};

RSS::AutoDownloader::instance()->renameRule(ruleName, newRuleName);
}
Expand All @@ -167,7 +167,7 @@ void RSSController::removeRuleAction()
{
requireParams({u"ruleName"_s});

const QString ruleName {params()[u"ruleName"_s].trimmed()};
const QString ruleName {params()[u"ruleName"_s]};
RSS::AutoDownloader::instance()->removeRule(ruleName);
}

Expand Down

0 comments on commit 308789a

Please sign in to comment.